Fix incorrect -ReportSummary Pester test grouping - #2057
Merged
Andy Jordan (andyleejordan) merged 1 commit intoFeb 17, 2025
Merged
Fix incorrect -ReportSummary Pester test grouping#2057Andy Jordan (andyleejordan) merged 1 commit into
Andy Jordan (andyleejordan) merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Matěj Kafka (MatejKafka)
requested review from
Andy Jordan (andyleejordan) and
Christoph Bergmeister (bergmeister)
as code owners
February 11, 2025 00:00
Andy Jordan (andyleejordan)
approved these changes
Feb 11, 2025
Andy Jordan (andyleejordan)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Oh yeah, you're quite right. Thanks!
Sorry, something went wrong.
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
February 11, 2025 20:14
Christoph Bergmeister (bergmeister)
approved these changes
Feb 17, 2025
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Restarted CI check, if that's green, happy with it
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes grouping of Pester tests where tests for -ReportSummary and a few other parameters were (probably accidentally) nested inside another Describe block. Recommend reviewing the diff locally, GitHub diff rendering is very confused (the commit just removes a level of indentation and moves a single }).
PR Checklist