Invoke-ScriptAnalyzer: Include parse errors in reported error count - #2069
Merged
Andy Jordan (andyleejordan) merged 1 commit intoMar 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Matěj Kafka (MatejKafka)
requested review from
Andy Jordan (andyleejordan) and
Christoph Bergmeister (bergmeister)
as code owners
March 1, 2025 02:17
Comment thread
Engine/Commands/InvokeScriptAnalyzerCommand.cs
Andy Jordan (andyleejordan)
approved these changes
Mar 13, 2025
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
March 13, 2025 16:28
Andy Jordan (andyleejordan)
force-pushed
the
report-summary-parse-errors
branch
from
d6d1f36 to
3390d78
Compare
March 13, 2025 16:54
Previously, parse error were not reported in the summary. With this commit, the exit code from -EnableExit matches the number of reported issues.
Andy Jordan (andyleejordan)
force-pushed
the
report-summary-parse-errors
branch
from
3390d78 to
38f2c98
Compare
March 13, 2025 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously, parse error were not reported in the summary. With this PR, the exit code from -EnableExit matches the number of diagnostics reported by -ReportSummary and parse errors are included under errors. Since -ReportSummary output is sent directly to the host, I don't believe this to be a breaking change.
PR Checklist