PSReviewUnusedParameter false positive for ValueFromPipeline - #2072
Merged
Andy Jordan (andyleejordan) merged 5 commits intoMar 13, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Liam Peters (liamjpeters)
marked this pull request as ready for review
March 4, 2025 09:36
Liam Peters (liamjpeters)
requested review from
Andy Jordan (andyleejordan) and
Christoph Bergmeister (bergmeister)
as code owners
March 4, 2025 09:36
Andy Jordan (andyleejordan)
approved these changes
Mar 5, 2025
Comment thread
Rules/ReviewUnusedParameter.cs
Outdated
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
March 6, 2025 20:00
auto-merge was automatically disabled
March 10, 2025 19:30
Head branch was pushed to by a user without write access
Christoph Bergmeister (bergmeister)
approved these changes
Mar 13, 2025
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM, thanks, retriggered CI
Sorry, something went wrong.
…t directly contains variable usage of $_ or $PSItem. Then when we encounted a parameter with ValueFromPipeline set, we consider whether we saw usage within a process block by automatic variable.
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Andy Jordan (andyleejordan)
force-pushed
the
#1840PSReviewUnusedParameterVsValueFromPipeline
branch
from
95e1486 to
d83b1d9
Compare
March 13, 2025 17:05
Liam Peters (liamjpeters)
deleted the
#1840PSReviewUnusedParameterVsValueFromPipeline
branch
August 7, 2025 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Whether good practice or not, a parameter defined with ValueFromPipeline is flagged as unused when referred to by $_ or $PSItem within the process block of a function.
This PR checks for ValueFromPipeline when the parameter's usage is inspected. If set, $_ and $PSItem count towards it's usage when seen in a process block.
Fixes #1840
PR Checklist