FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for PSUseConsistantWhiteSpace when using statement is present by AlexandraDorey · Pull Request #2091 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Fix for PSUseConsistantWhiteSpace when using statement is present - #2091

Merged
Andy Jordan (andyleejordan) merged 6 commits into
PowerShell:mainfrom
AlexandraDorey:FixUsing
Apr 4, 2025
ConversationCommits (6)ChecksFiles changed
Merged

Fix for PSUseConsistantWhiteSpace when using statement is present#2091
Andy Jordan (andyleejordan) merged 6 commits into
PowerShell:mainfrom
AlexandraDorey:FixUsing

Conversation

AlexandraDorey-Magnet (AlexandraDorey) commented Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

The addition of an using statement can cause the PSUseConsistant white space to fail due to how the InternalVisit of the UsingStatementAst is implemented in a slightly different way than other ASTs. See issue 2089 for more details.

PR Checklist

AlexandraDorey-Magnet (AlexandraDorey) commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Closed
Andy Jordan (andyleejordan) approved these changes Apr 1, 2025
View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey cool, good debugging. Read through your issue, I think you're right and this makes sense. Just approved the tests workflow.

AlexandraDorey-Magnet (AlexandraDorey) changed the title WIP - Fix for PSUseConsistantWhiteSpace when using statement is present Fix for PSUseConsistantWhiteSpace when using statement is present Apr 1, 2025
Christoph Bergmeister (bergmeister) reviewed Apr 3, 2025
View reviewed changes
Comment thread NuGet.Config Outdated
Christoph Bergmeister (bergmeister) approved these changes Apr 3, 2025
View reviewed changes

Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, well done

AlexandraDorey-Magnet (AlexandraDorey) commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Fixed the nits up, I'm not super familiar with github but I assume I can merge my commits into one commit when the PR merges or should I do that in by branch first? Otherwise should be good to merge once the tests run again :)

Andy Jordan (andyleejordan) enabled auto-merge (squash) April 4, 2025 00:51

Andy Jordan (andyleejordan) commented Apr 4, 2025

Copy link
Copy Markdown
Member

Sure can!

Andy Jordan (andyleejordan) merged commit 2287a13 into PowerShell:main Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Andy Jordan (andyleejordan) andyleejordan approved these changes
Christoph Bergmeister (bergmeister) bergmeister approved these changes

Assignees

No one assigned

Labels

Issue - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL