FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change CommandInfo lookup for commands in the form `module\cmdletName` by liamjpeters · Pull Request #2125 · PowerShell/PSScriptAnalyzer · GitHub

/ PSScriptAnalyzer Public

Change CommandInfo lookup for commands in the form module\cmdletName - #2125

Merged
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:mainfrom
liamjpeters:#2123CommandInfoCacheIssue
Oct 14, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Change CommandInfo lookup for commands in the form module\cmdletName#2125
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:mainfrom
liamjpeters:#2123CommandInfoCacheIssue

Conversation

Liam Peters (liamjpeters) commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

When the CommandInfoCache is used to lookup some fully qualified commands (by way of Get-Command), a nested module name is returned.

PR changes CommandInfoCache when a CommandInfo is looked up for a command in the form module\cmdletName. It passes this module name hint along to Get-Command to allow correct resolution.

With the MicrosoftTeams module installed, as an example, running:

Get-Command -Name 'MicrosoftTeams\Get-CsOnlineLisCivicAddress'

Reports the commands module as Microsoft.Teams.ConfigAPI.Cmdlets.

Instead running:

Get-Command -Name 'Get-CsOnlineLisCivicAddress' -Module 'MicrosoftTeams'

Correctly reports the module as MicrosoftTeams.

Also happens for Az.resources\Get-AzRoleEligibilitySchedule

Fixes #2123
Fixes #2023

PR Checklist

Andy Jordan (andyleejordan) approved these changes Oct 13, 2025
View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perfect, thanks so much! Weird, seems like there may be a bug in Get-Command itself because that behavior is changing between the module-qualified command name, and passing the module name as a separate parameter. Maybe a sorting issue, we don't know. This is a good workaround given your tests.

Andy Jordan (andyleejordan) commented Oct 13, 2025

Copy link
Copy Markdown
Member

Liam Peters (@liamjpeters) can you rebase this so the PR checks trigger and I can merge it? Thanks!

Liam Peters (liamjpeters) commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

My Git-Fu is not strong Andy Jordan (@andyleejordan) 😅 Did I do it?

Andy Jordan (andyleejordan) commented Oct 14, 2025

Copy link
Copy Markdown
Member

You did it! CI Tests are running now 😄

Liam Peters (liamjpeters) commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

If only it had succeeded. Drat.

The offending test that failed on the mac build runner:

PSScriptAnalyzer/Tests/Rules/UseCorrectCasing.tests.ps1

Lines 77 to 85 in ea70855

It "Does not throw when correcting certain cmdlets (issue 1516)" {
$scriptDefinition = 'Get-Content;Test-Path;Get-ChildItem;Get-Content;Test-Path;Get-ChildItem'
$settings = @{ 'Rules' = @{ 'PSUseCorrectCasing' = @{ 'Enable' = $true; CheckCommands = $true; CheckKeywords = $true; CheckOperators = $true } } }
{
1..100 |
ForEach-Object { $null = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -Settings $settings -ErrorAction Stop }
} |
Should -Not -Throw
}

I don't have a mac to try it on, but the failure looks like the runspace safety issue with the command info cache - an old discussion and summary in issue #1867.

I've run the test in a loop and managed to get it to fail once with the same error on my Windows machine after about 20 mins of running. I've managed the same on the master branch just now:

I'm not sure how to check whether this PR makes this issue more prevalent or if it's the same as it has been and just got unlucky with the CI run.

Andy Jordan (andyleejordan) commented Oct 14, 2025

Copy link
Copy Markdown
Member

That seems like it's a flaky test, I'm rerunning the CI.

Andy Jordan (andyleejordan) merged commit 08bb38b into PowerShell:main Oct 14, 2025
5 of 7 checks passed
Liam Peters (liamjpeters) deleted the #2123CommandInfoCacheIssue branch October 15, 2025 08:01
Jesse Houwing (jessehouwing) mentioned this pull request Aug 19, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Andy Jordan (andyleejordan) andyleejordan approved these changes
Christoph Bergmeister (bergmeister) Awaiting requested review from bergmeister bergmeister is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code Formatter: Don't remove module names from cmdlet calls UseCorrectCasing removes <module>\ from <module>\<cmdlet> in vscode-powershell

2 participants

Back | FazBrowse Home | New Git URL