feat(tests): added closing bracket test for formatting presets - #2161
Merged
Andy Jordan (andyleejordan) merged 2 commits intoMar 18, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot started reviewing on behalf of
Olav Rønnestad Birkeland (o-l-a-v)
March 7, 2026 12:39
View session
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression-style tests for Invoke-Formatter behavior around if/else close-brace placement across formatting presets, to preserve expected formatting semantics while broader preset work remains blocked upstream.
Changes:
- Adds new Pester context validating if/else formatting output for CodeFormattingAllman, CodeFormattingOTBS, and CodeFormattingStroustrup.
- Introduces canonical input/expected script definitions for the three brace styles and asserts formatter round-trips between them.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
Tests/Rules/PlaceCloseBrace.tests.ps1
Outdated
Comment thread
Tests/Rules/PlaceCloseBrace.tests.ps1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Olav Rønnestad Birkeland (o-l-a-v)
requested review from
a team and
Christoph Bergmeister (bergmeister)
as code owners
March 7, 2026 12:47
Christoph Bergmeister (bergmeister)
approved these changes
Mar 9, 2026
Christoph Bergmeister (bergmeister)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Always good to have more tests :-)
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
requested a review
from Andy Jordan (andyleejordan)
March 18, 2026 19:13
Olav Rønnestad Birkeland (o-l-a-v)
deleted the
feat/add-test-for-formatting-presets-square-bracket-handling
branch
March 19, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Since #2158 is blocked due to PSScriptAnalyzer formatting limitations #2045 (comment) I thought I could at least add the relevant tests I created in that PR, without the proposed new preset OTPS.
PR Checklist