WIP Fix Exception when trying to analyze custom attribute that is being defined in different file - #995
Closed
Christoph Bergmeister (bergmeister) wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Christoph Bergmeister (bergmeister)
changed the base branch from
development
to
master
June 13, 2020 18:08
6 tasks
Rob Holt (rjmholt)
marked this pull request as draft
April 21, 2021 21:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #966
This is a quick fix. I would like to understand more details of it. If the definition is not part of a file being analysed by PSSA or know to PowerShell then we cannot do anything. But maybe I can improve the overall pre-analysis or something else.
A test is to be written.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.