FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

$PSCulture follows CurrentThread.CurrentCulture by iSazonov · Pull Request #10138 · PowerShell/PowerShell · GitHub

/ PowerShell Public

$PSCulture follows CurrentThread.CurrentCulture - #10138

Merged
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
iSazonov:psculture-from-thread
Oct 7, 2019
ConversationCommits (3)ChecksFiles changed
Merged

$PSCulture follows CurrentThread.CurrentCulture#10138
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
iSazonov:psculture-from-thread

Conversation

Ilya (iSazonov) commented Jul 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Now $PSCulture gets the value from CurrentThread.CurrentCulture

Close #3831

PowerShell Committee approved the change in #3831

PR Context

PR Checklist

Ilya (iSazonov) added Committee-Reviewed PS-Committee has reviewed this and made a decision CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log labels Jul 12, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.2 milestone Jul 12, 2019
Ilya (iSazonov) self-assigned this Jul 12, 2019

Ilya (iSazonov) commented Jul 12, 2019

Copy link
Copy Markdown
Collaborator Author

PoshChan-Bot (@PoshChan) Please restart Macos

Ilya (iSazonov) commented Jul 12, 2019

Copy link
Copy Markdown
Collaborator Author

PoshChan-Bot (@PoshChan) Please retry Macos

PoshChan-Bot (PoshChan) commented Jul 12, 2019

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov), successfully started retry of PowerShell-CI-macOS

Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Jul 12, 2019
Ilya (iSazonov) mentioned this pull request Jul 29, 2019
Closed
8 tasks
Ilya (iSazonov) removed the Documentation Needed in this repo Documentation is needed in this repo label Jul 29, 2019

Ilya (iSazonov) commented Aug 20, 2019

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Travis Plunk (@TravisEz13) Since the PR was approved by PowerShell Committee please review the code.

Ilya (iSazonov) commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator Author

Rebased to get latest updates.

Travis Plunk (TravisEz13) removed this from the 7.0.0-preview.4 milestone Sep 12, 2019

Ilya (iSazonov) commented Sep 17, 2019

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Travis Plunk (@TravisEz13) Could you please continue the review?

Ilya (iSazonov) commented Sep 20, 2019

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Have you any concerns about the PR?

Ilya (iSazonov) commented Oct 2, 2019

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Friendly ping.

Ilya (iSazonov) merged commit 6a36bb4 into PowerShell:master Oct 7, 2019
Ilya (iSazonov) deleted the psculture-from-thread branch October 7, 2019 09:17

Deleted user (ghost) commented Oct 23, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

ghost mentioned this pull request Oct 23, 2019
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
$PSCulture follows CurrentThread.CurrentCulture (PowerShell#10138)
27c565c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Travis Plunk (TravisEz13) TravisEz13 approved these changes
Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
+1 more reviewer
PoshChan-Bot (PoshChan) PoshChan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

Ilya (iSazonov)

Labels

CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.0.0-preview.5

Development

Successfully merging this pull request may close these issues.

Get-Culture and $PSCulture do not (consistently) reflect in-session changes to another culture

3 participants

Back | FazBrowse Home | New Git URL