FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add working directory parameter to `Start-Job` by davinci26 · Pull Request #10324 · PowerShell/PowerShell · GitHub

Add working directory parameter to Start-Job - #10324

Merged
Aditya Patwardhan (adityapatwardhan) merged 16 commits into
PowerShell:masterfrom
davinci26:feat-startJobWorkingDirectory
Sep 11, 2019
Merged

Add working directory parameter to Start-Job#10324
Aditya Patwardhan (adityapatwardhan) merged 16 commits into
PowerShell:masterfrom
davinci26:feat-startJobWorkingDirectory

Conversation

Sotiris Nanopoulos (davinci26) commented Aug 8, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary and Changes

Solves the same problem as #10274 (for future reference you can read the discussion) with a different implementation

  1. Enables the workingDirectory parameter when PowerShell runs in Server mode
  2. Uses the workingDirectory PowerShell parameter to implement start-job workingDirectory

Awaiting your feedback and comments!

PR Context

Fix #4287

PR Checklist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall looks good. Just a few comments.

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 8, 2019
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The changes look good to me. However, it appears the rebase didn't work correctly because I now see changes from other PRs here.

Copy link
Copy Markdown
Contributor Author

I saw that as well, I am working on a fix as we speak

Sotiris Nanopoulos added 5 commits August 9, 2019 09:03
…breaking change in PowerShellProcessInstance by making parameter optional and renamed parameter to workingDirectory in OutOfProcServerMediator to make it consistent
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 9, 2019
…d improved testing using testcases patterns & testDrive
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 9, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) I think I have addressed all your feedback. Let me know what you think

Aditya Patwardhan (adityapatwardhan) changed the title Feat start job working directory Add working directory parameter to Start-Job Aug 20, 2019
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 20, 2019

Sotiris Nanopoulos (davinci26) commented Aug 21, 2019
edited
Loading

Copy link
Copy Markdown
Contributor Author

I also created some gifs to demo it

Start Job Working Directory Mac OSX

Start Job Working Directory Windows

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 21, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) lemme know what you think about the changes now :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some more changes in the tests. Thanks for your patience.

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 5, 2019

Copy link
Copy Markdown
Member

Please also look at CodeFactor issues.

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) I will do my best to clean up the CodeFactor issues in the files that I have touched.

But there are some issues that are related to documentation of parameters in functions that I have not touched so I am not sure if I am the best person to write this documentation.

Would this be ok?

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 6, 2019
Aditya Patwardhan (adityapatwardhan) merged commit f69f30b into PowerShell:master Sep 11, 2019

Copy link
Copy Markdown
Member

Sotiris Nanopoulos (@davinci26) Thank you for your contribution!

Copy link
Copy Markdown

🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start-Job needs a -WorkingDirectory parameter

4 participants


Back | FazBrowse Home | New Git URL