| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Overall looks good. Just a few comments.
Sorry, something went wrong.
There was a problem hiding this comment.
The changes look good to me. However, it appears the rebase didn't work correctly because I now see changes from other PRs here.
Sorry, something went wrong.
|
I saw that as well, I am working on a fix as we speak |
Sorry, something went wrong.
…breaking change in PowerShellProcessInstance by making parameter optional and renamed parameter to workingDirectory in OutOfProcServerMediator to make it consistent
…d improved testing using testcases patterns & testDrive
|
Aditya Patwardhan (@adityapatwardhan) I think I have addressed all your feedback. Let me know what you think |
Sorry, something went wrong.
…d foreach in the tests
|
I also created some gifs to demo it Start Job Working Directory Mac OSX Start Job Working Directory Windows |
Sorry, something went wrong.
|
Aditya Patwardhan (@adityapatwardhan) lemme know what you think about the changes now :) |
Sorry, something went wrong.
There was a problem hiding this comment.
Some more changes in the tests. Thanks for your patience.
Sorry, something went wrong.
|
Please also look at CodeFactor issues. |
Sorry, something went wrong.
|
Aditya Patwardhan (@adityapatwardhan) I will do my best to clean up the CodeFactor issues in the files that I have touched. But there are some issues that are related to documentation of parameters in functions that I have not touched so I am not sure if I am the best person to write this documentation. Would this be ok? |
Sorry, something went wrong.
|
Sotiris Nanopoulos (@davinci26) Thank you for your contribution! |
Sorry, something went wrong.
|
🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary and Changes
Solves the same problem as #10274 (for future reference you can read the discussion) with a different implementation
Awaiting your feedback and comments!
PR Context
Fix #4287
PR Checklist