| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
per https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md it seems the current style is correct? Also, I believe only public fields have Pascal Casing otherwise it would be camelCasing
Sorry, something went wrong.
There was a problem hiding this comment.
The properties is used in other classes and files.
It seems it is bad if we see a code like follow in another file:
functionContext._scriptBlock.Ast.ExtentI believe the properties should be public in the internal class. Thoughts?
Sorry, something went wrong.
There was a problem hiding this comment.
I removed all extra changes and refactor commits.
Sorry, something went wrong.
|
🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Fix style issue in Compiler.cs file.
Please review commit by commit. There is a lot of commits but everyone is small and simple.
PR Context
CodeFactor has two nice metrics:
If we take a file with this two metrics being large there is a high probability that we will get a PR with a large number of style errors.
So make sense proactively fix style issues in such files and save a time of code reviewers later.
PR Checklist