FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Cleanup style issues in Compiler.cs by iSazonov · Pull Request #10368 · PowerShell/PowerShell · GitHub

Cleanup style issues in Compiler.cs - #10368

Merged
Ilya (iSazonov) merged 14 commits into
PowerShell:masterfrom
iSazonov:cleanup-style-compiler-1
Oct 22, 2019
Merged

Cleanup style issues in Compiler.cs#10368
Ilya (iSazonov) merged 14 commits into
PowerShell:masterfrom
iSazonov:cleanup-style-compiler-1

Conversation

Copy link
Copy Markdown
Collaborator

PR Summary

Fix style issue in Compiler.cs file.

Please review commit by commit. There is a lot of commits but everyone is small and simple.

PR Context

CodeFactor has two nice metrics:

  • how many a file was changed
  • how many a file has style issues

If we take a file with this two metrics being large there is a high probability that we will get a PR with a large number of style errors.

So make sense proactively fix style issues in such files and save a time of code reviewers later.

PR Checklist

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

per https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md it seems the current style is correct? Also, I believe only public fields have Pascal Casing otherwise it would be camelCasing

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The properties is used in other classes and files.
It seems it is bad if we see a code like follow in another file:

  functionContext._scriptBlock.Ast.Extent

I believe the properties should be public in the internal class. Thoughts?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I removed all extra changes and refactor commits.

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Sep 18, 2019
Ilya (iSazonov) force-pushed the cleanup-style-compiler-1 branch from efe9c63 to 224256c Compare October 21, 2019 14:47
Ilya (iSazonov) force-pushed the cleanup-style-compiler-1 branch 2 times, most recently from 1344fdc to 4038e0a Compare October 21, 2019 15:17
Ilya (iSazonov) force-pushed the cleanup-style-compiler-1 branch from 4038e0a to 7b125f4 Compare October 21, 2019 15:24
Ilya (iSazonov) merged commit 89c6603 into PowerShell:master Oct 22, 2019
Ilya (iSazonov) deleted the cleanup-style-compiler-1 branch October 22, 2019 08:46
Ryan Yates (kilasuit) pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL