| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Ilya (@iSazonov) The same DLL is used by AssignProcessToJobObjectDllName and QueryInformationJobObjectDllName. Do these also not work on Win7? If we are replacing them with kernel32.dll, have you verified the change on win7throughwin10`? If replacing with kernel32.dll works, should we be removing the definitions from PInvokeDllNames.cs. |
Sorry, something went wrong.
|
Aditya Patwardhan (@adityapatwardhan) I removed all links to api-ms-win-core-job-l2-1-0.dll and now it works for me on Windows 7.
There is already some unused consts, the list is large and numerated, also we could want to use ApiSets again after Windows 7 EOL. I think we need to keep the consts. |
Sorry, something went wrong.
|
Do we know if things are still working properly on NanoServer and Windows IoT after changing to kernal32.dll? |
Sorry, something went wrong.
|
I can not test on Nano and IoT. Also I found https://www.geoffchappell.com/studies/windows/win32/apisetschema/history/sets61.htm where we can see that there is sometimes automapping (for Windows 7). |
Sorry, something went wrong.
|
I have verified that the change works on NanoServer 1903 image. |
Sorry, something went wrong.
|
🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
|
Hey, shouldn't we remove the corresponding constants from the PinvokeDllNames class since they are unused now? |
Sorry, something went wrong.
|
Friedrich von Never (@ForNeVeR) We did not remove the constants because we will revert the change after Windows 7 EOL. |
Sorry, something went wrong.
|
Okay, thanks. |
Sorry, something went wrong.
|
🎉v6.2.4 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Fix #6561
PR Context
PR Checklist