Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger by KirkMunro · Pull Request #10503 · PowerShell/PowerShell · GitHub

PR Summary

Prior to this fix, if you created, modified, or removed a breakpoint in a nested debugger or inside of a job debugger, whatever change you made would be applied to the breakpoint with the corresponding breakpoint ID in the host runspace debugger. This fix removes the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger.

PR Context

See discussion with Paul Higinbotham (@PaulHigin) in #10167.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

LGTM

Co-Authored-By: Ilya <darpa@yandex.ru>

test cases should be independent.

But this is not blocking.

Travis Plunk (@TravisEz13) A question about this for my own knowledge: by independent do you mean that the specific test for that issue should be in a different Describe or Context invocation? Or do you mean that the comments shouldn't be there, because they infer a dependency between that test and the issue it resolves?

Hello Travis Plunk (@TravisEz13)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

…roneously replicated to the host runspace debugger (PowerShell#10503) * fix PowerShell#10167 * Update test/powershell/SDK/Breakpoint.Tests.ps1 Co-Authored-By: Ilya <darpa@yandex.ru>

🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…roneously replicated to the host runspace debugger (PowerShell#10503) * fix PowerShell#10167 * Update test/powershell/SDK/Breakpoint.Tests.ps1 Co-Authored-By: Ilya <darpa@yandex.ru>

fix PowerShell#10167

1929862

Kirk Munro (KirkMunro) requested a review from Paul Higinbotham (PaulHigin) as a code owner September 9, 2019 17:25

Paul Higinbotham (PaulHigin) approved these changes Sep 9, 2019

View reviewed changes

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 10, 2019

Ilya (iSazonov) added this to the 7.0.0-preview.4 milestone Sep 10, 2019

Ilya (iSazonov) reviewed Sep 10, 2019

View reviewed changes

Comment thread test/powershell/SDK/Breakpoint.Tests.ps1 Outdated

Ilya (iSazonov) requested review from Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) September 10, 2019 06:21

Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Sep 10, 2019

Update test/powershell/SDK/Breakpoint.Tests.ps1

38362ad

Co-Authored-By: Ilya <darpa@yandex.ru>

Travis Plunk (TravisEz13) changed the title Fix #10167 by removing HandleBreakpointUpdated event handler that should not have been there in the first place Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger Sep 10, 2019

Travis Plunk (TravisEz13) reviewed Sep 10, 2019

View reviewed changes

Travis Plunk (TravisEz13) added the AutoMerge informs the bot to automerge the PR label Sep 10, 2019

ghost merged commit 096a78f into PowerShell:master Sep 10, 2019

Kirk Munro (KirkMunro) deleted the issue-10167-fix branch September 10, 2019 23:24

ghost mentioned this pull request Sep 19, 2019

Updating breakpoints in a nested debugger or in a job debugger results in breakpoints with the same id in the parent being overwritten #10167

Closed

This pull request was closed.

+                          # Ensure that breakpoints were not created in the default runspace.
+                          # Prior to this issue being fixed, breakpoints with the same id
+                          # would be created or updated in the default runspace.
+                          $host.Runspace.Debugger.GetBreakpoints() | Should -BeNullOrEmpty

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger by KirkMunro · Pull Request #10503 · PowerShell/PowerShell · GitHub

Uh oh!

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger - #10503

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger#10503
2 commits merged into
PowerShell:masterfrom
KirkMunro:issue-10167-fix

Kirk Munro (KirkMunro) commented Sep 9, 2019

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) Sep 10, 2019

Uh oh!

Travis Plunk (TravisEz13) Sep 10, 2019

Uh oh!

Kirk Munro (KirkMunro) Sep 10, 2019

Uh oh!

Deleted user (ghost) commented Sep 10, 2019

Uh oh!

Deleted user (ghost) commented Sep 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger by KirkMunro · Pull Request #10503 · PowerShell/PowerShell · GitHub

Uh oh!

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger - #10503

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger#105032 commits merged intoPowerShell:masterPowerShell/PowerShell:masterfrom KirkMunro:issue-10167-fixKirkMunro/PowerShell:issue-10167-fixCopy head branch name to clipboard

Conversation

Kirk Munro (KirkMunro) commented Sep 9, 2019

PR Summary

PR Context

PR Checklist

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

Kirk Munro (KirkMunro) Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

Deleted user (ghost) commented Sep 10, 2019

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Deleted user (ghost) commented Sep 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger#10503
2 commits merged into
PowerShell:masterfrom
KirkMunro:issue-10167-fix