Add `Get-ChildItem` test by iSazonov · Pull Request #10507 · PowerShell/PowerShell · GitHub

PR Summary

Add new test for #3724 to exclude a regression.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

/cc Michael Klement (@mklement0) for information.

I suggest adding another test where escaped and [ and ] are combined with * or ? - because a bug currently lurks there (you inexplicably need an extra round of escaping then); e.g., Get-Item -Path 'a```[b*' breaks at the moment.

Michael Klement (@mklement0) Thanks!

Done.

Aditya Patwardhan (@adityapatwardhan) I don't use -Casesso as not to add a new Describe.

I removed the test because it seems it looks like a bug. I hope we will discuss this in new issue.

Ilya (@iSazonov): We have a catch-all issue at #7999 and one regarding invalid patterns getting ignored #6733. Perhaps put the tests in commented out for now, with a link to the issues?

Also note that ] doesn't need escaping, as long as the [ is escaped; so, given that Get-ChildItem -Path 'a```[b`]' works, but Get-ChildItem -Path 'a```[b]' (no escaping of ]) doesn't, that should be considered another bug.

Perhaps put the tests in commented out for now, with a link to the issues?

We could add tests in pending state but I think it will be more useful if it is in related discussions than hidden in tests.

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Add Get-ChildItem test

a6eebed

Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Sep 10, 2019

Ilya (iSazonov) added this to the 7.0.0-preview.4 milestone Sep 10, 2019

Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Aditya Patwardhan (adityapatwardhan) September 10, 2019 03:41

Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Sep 10, 2019

PoshChan-Bot (PoshChan) reviewed Sep 10, 2019

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1

Aditya Patwardhan (adityapatwardhan) changed the title Add Get-ChildItem test Add Get-ChildIte test Sep 11, 2019

Aditya Patwardhan (adityapatwardhan) changed the title Add Get-ChildIte test Add Get-ChildItem test Sep 11, 2019

Aditya Patwardhan (adityapatwardhan) requested changes Sep 11, 2019

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1 Outdated

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1 Outdated

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 11, 2019

Michael Klement (mklement0) reviewed Sep 11, 2019

View reviewed changes

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 12, 2019

Address feedback

a865241

PoshChan-Bot (PoshChan) reviewed Sep 12, 2019

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1

PoshChan-Bot (PoshChan) reviewed Sep 12, 2019

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1

PoshChan-Bot (PoshChan) reviewed Sep 12, 2019

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1

Remove test with wildcard

abec736

Travis Plunk (TravisEz13) modified the milestones: 7.0.0-preview.4, 7.0.0-preview.5 Sep 12, 2019

Aditya Patwardhan (adityapatwardhan) approved these changes Oct 4, 2019

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit d7458c4 into PowerShell:master Oct 4, 2019

Ilya (iSazonov) deleted the add-test-dir-wildcard branch October 4, 2019 02:59

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Add Get-ChildItem test (PowerShell#10507 )

b2564aa

+                          try {
+                              New-Item -Type File 'a`[b]' -ErrorAction SilentlyContinue > $null
+                              $WithInclude = Get-ChildItem * -Include 'a```[b`]'
+                              $WithPath = Get-ChildItem -Path 'a```[b`]'

Add `Get-ChildItem` test by iSazonov · Pull Request #10507 · PowerShell/PowerShell · GitHub

Uh oh!

Add Get-ChildItem test - #10507

Add Get-ChildItem test#10507
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
iSazonov:add-test-dir-wildcard

Ilya (iSazonov) commented Sep 10, 2019 •
edited
Loading

Uh oh!

Uh oh!

Ilya (iSazonov) commented Sep 10, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Michael Klement (mklement0) Sep 11, 2019

Uh oh!

Ilya (iSazonov) Sep 12, 2019

Uh oh!

Ilya (iSazonov) Sep 12, 2019

Uh oh!

Michael Klement (mklement0) Sep 12, 2019 •
edited
Loading

Uh oh!

Uh oh!

Ilya (iSazonov) Sep 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Deleted user (ghost) commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add `Get-ChildItem` test by iSazonov · Pull Request #10507 · PowerShell/PowerShell · GitHub

Uh oh!

Add Get-ChildItem test - #10507

Add Get-ChildItem test#10507Aditya Patwardhan (adityapatwardhan) merged 3 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom iSazonov:add-test-dir-wildcardiSazonov/PowerShell:add-test-dir-wildcardCopy head branch name to clipboard

Conversation

Ilya (iSazonov) commented Sep 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Ilya (iSazonov) commented Sep 10, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Michael Klement (mklement0) Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Sep 12, 2019

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Sep 12, 2019

Choose a reason for hiding this comment

Uh oh!

Michael Klement (mklement0) Sep 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Deleted user (ghost) commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add Get-ChildItem test#10507
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
iSazonov:add-test-dir-wildcard

Ilya (iSazonov) commented Sep 10, 2019 •
edited
Loading

Michael Klement (mklement0) Sep 12, 2019 •
edited
Loading