FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1 by Orca88 · Pull Request #10526 · PowerShell/PowerShell · GitHub

Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1 - #10526

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
Orca88:patch-1
Sep 16, 2019
Merged

Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1#10526
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
Orca88:patch-1

Conversation

Orca88 commented Sep 12, 2019
edited by iSazonov
Loading

Copy link
Copy Markdown
Contributor

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string. Properly checking with [String]::IsNullOrEmpty() solves the problem.

PR Summary

Fix #7787

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string. Properly checking with [String]::IsNullOrEmpty() solves the problem.

PR Context

Restore expected behavior to match documentation of PowerShell Core installation.

PR Checklist

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string.  Properly checking with [String]::IsNullOrEmpty() solves the problem.
Orca88 changed the title Fix for issue #7787 Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1 Sep 12, 2019
Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Sep 13, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Sep 13, 2019
Travis Plunk (TravisEz13) merged commit fc0e3bc into PowerShell:master Sep 16, 2019

Copy link
Copy Markdown
Collaborator

Orca88 Thanks for your contribution!

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
…ellHome` parameter (PowerShell#10526)

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string.  Properly checking with [String]::IsNullOrEmpty() solves the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install-PowerShellRemoting.ps1 fails when run without specifying -PowerShellHome in PowerShell 6.1 GA

4 participants


Back | FazBrowse Home | New Git URL