| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Perf win ~2.3%
This comment is not accurate. This code path is hit 4 or 5 times at most when Runspace opens. There are many other places checks for file existence, such as in PowerShellConfig when reading the config json file. So removing this check won't eliminate all FileSystem.FileExist calls.
Sorry, something went wrong.
|
Can you update your PR description to not say a 2.3% perf win? |
Sorry, something went wrong.
|
It's still not accurate as there may be other calls to File.Exist within the code paths hit by RunspaceFactory.CreateRunspace. I suggest to remove the Perf Win part in the PR description. |
Sorry, something went wrong.
|
Done. |
Sorry, something went wrong.
|
Dongbo Wang (@daxian-dbw) Could you please merge? |
Sorry, something went wrong.
|
🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Comments says that the code was optimized in Windows PowerShell but there is still room for improvements that is important for scenarios actively using runspaces and startup.
Remove check that file exist.

The code came from Windows PowerShell but now all the standard dlls is placed in $PSHome and we have no need to search them in other paths by the dll name.
Remove some obvious allocations
PR Context
PR Checklist