FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add env var to differentiate client/server telemetry in MSI by SteveL-MSFT · Pull Request #10612 · PowerShell/PowerShell · GitHub

Add env var to differentiate client/server telemetry in MSI - #10612

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:msi-telemetry
Sep 24, 2019
Merged

Add env var to differentiate client/server telemetry in MSI#10612
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:msi-telemetry

Conversation

Steve Lee (SteveL-MSFT) commented Sep 24, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

When installed via MSI, create POWERSHELL_DISTRIBUTION_CHANNEL env var that will be picked up by telemetry to report if the Windows system is client or server by using: msi:<ProductName> where is retrieved from the registry under HKLM:\Software\Microsoft\Windows NT\CurrentVersion\ProductName.

Also fixed some formatting of the xml where it was one column over too much.

PR Context

Currently, we have no way to differentiating client and server skus from our Windows telemetry.

PR Checklist

add env var to differentiate client/server in telemetry when installed via MSI
Comment thread assets/Product.wxs Outdated
Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 24, 2019
Steve Lee (SteveL-MSFT) changed the title Add env var to differentiate client/server in telemetry when installed via MSI WIP:Add env var to differentiate client/server in telemetry when installed via MSI Sep 24, 2019
Steve Lee (SteveL-MSFT) changed the title WIP:Add env var to differentiate client/server in telemetry when installed via MSI Add env var to differentiate client/server in telemetry when installed via MSI Sep 24, 2019
Change id to use PascalCasing to be consistent
Travis Plunk (TravisEz13) changed the title Add env var to differentiate client/server in telemetry when installed via MSI Add env var to differentiate client/server telemetry in MSI Sep 24, 2019
Travis Plunk (TravisEz13) merged commit 146f11b into PowerShell:master Sep 24, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Steve Lee (SteveL-MSFT) deleted the msi-telemetry branch June 6, 2020 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL