Replace CR and new line with a 0x23CE character by TravisEz13 · Pull Request #10616 · PowerShell/PowerShell · GitHub

PR Summary

Replace CR and new line with a 0x23CE character

PR Context

Trying to document how to use logging with Azure Log Analytics and RSyslog converting these to #012 and #013

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

This check is not needed.

Why? This is only an issues for SysLog, not OsLog on macOS

Got it. Closed

In the case it would be good to have the protection comment in the code.

I can repeat the comment if you want

It is explained on line 1584

Talked with Travis Plunk (@TravisEz13) about the concern of creating 3 large strings for Linux when the script itself is large.
Travis Plunk (@TravisEz13) will update the code to address that concern.

Why do we need this? `u{23CE} looks more clear for me.

The tests fail if we use the escape sequence.

I tried to copy and paster the code in console and lost the char. Also the tests become unreadable. I wonder why doesn't the Unicode syntax sugar work?

Ilya (@iSazonov) that's going to vary by the font you use. I worked with Rob Holt (@rjmholt) to come up with this solution. The previous solution that was working, was actually just looking for a ? which is less specific.

I remember that we had Unicode chars in files and it was a headache - editors silently break them. After that we made a conclusion to keep all files in ASCII.

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Replace CR and new line with a 0x23CE character

f4e6e0e

Travis Plunk (TravisEz13) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Sep 24, 2019

Travis Plunk (TravisEz13) added this to the 7.0.0-preview.5 milestone Sep 24, 2019

Travis Plunk (TravisEz13) changed the title Replace CR and new line with a 0x23CE character WIP: Replace CR and new line with a 0x23CE character Sep 24, 2019

PoshChan-Bot (PoshChan) reviewed Sep 24, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs Outdated

Dongbo Wang (daxian-dbw) reviewed Sep 25, 2019

View reviewed changes

Ilya (iSazonov) reviewed Sep 25, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs Outdated

Travis Plunk (TravisEz13) added 2 commits September 25, 2019 15:15

fix tests

cf598e2

update logging

8c70dce

Aditya Patwardhan (adityapatwardhan) approved these changes Sep 25, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs Outdated

PoshChan-Bot (PoshChan) reviewed Sep 25, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs

Travis Plunk (TravisEz13) added 2 commits September 25, 2019 15:49

fix codefactor issues

1b8ebe2

fix test issues

9cfcc60

PoshChan-Bot (PoshChan) reviewed Sep 25, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs

Dongbo Wang (daxian-dbw) reviewed Sep 25, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs Outdated

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs Outdated

address PR issues

07d23e2

Travis Plunk (TravisEz13) changed the title WIP: Replace CR and new line with a 0x23CE character Replace CR and new line with a 0x23CE character Oct 3, 2019

try making tests more percise

5947deb

Ilya (iSazonov) reviewed Oct 4, 2019

View reviewed changes

remove dead code

9ea47ab

Travis Plunk (TravisEz13) assigned Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) and unassigned Travis Plunk (TravisEz13) Oct 4, 2019

PoshChan-Bot (PoshChan) reviewed Oct 4, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs

PoshChan-Bot (PoshChan) reviewed Oct 4, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs

Aditya Patwardhan (adityapatwardhan) merged commit bf91246 into PowerShell:master Oct 7, 2019

Travis Plunk (TravisEz13) deleted the fix_linux_syslogs branch October 7, 2019 18:44

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Replace CR and new line with a 0x23CE character (PowerShell#10616 )

5e846d1

                           [string] $powershell = Join-Path -Path $PSHome -ChildPath 'pwsh'
                           $scriptBlockCreatedRegExTemplate = @"
-              Creating Scriptblock text \(1 of 1\):#012{0}(`u{23CE}|\?|#012)*ScriptBlock ID: [0-9a-z\-]*#012Path:.*
+              Creating Scriptblock text \(1 of 1\):#012{0}(⏎|#012)*ScriptBlock ID: [0-9a-z\-]*#012Path:.*

                               textToLog = textToLog.Replace('\u0000', '\u2400');
+              #if UNIX
+                              if (Platform.IsLinux)
+                              {

Replace CR and new line with a 0x23CE character by TravisEz13 · Pull Request #10616 · PowerShell/PowerShell · GitHub

Uh oh!

Replace CR and new line with a 0x23CE character - #10616

Replace CR and new line with a 0x23CE character#10616Aditya Patwardhan (adityapatwardhan) merged 8 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom TravisEz13:fix_linux_syslogsTravisEz13/PowerShell:fix_linux_syslogsCopy head branch name to clipboard

Conversation

Travis Plunk (TravisEz13) commented Sep 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Sep 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Deleted user (ghost) commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Replace CR and new line with a 0x23CE character#10616
Aditya Patwardhan (adityapatwardhan) merged 8 commits into
PowerShell:masterfrom
TravisEz13:fix_linux_syslogs

Travis Plunk (TravisEz13) commented Sep 24, 2019 •
edited
Loading

Ilya (iSazonov) Sep 26, 2019 •
edited
Loading