FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add back newline for grouping with `Format-Table` and `-Property` by SteveL-MSFT · Pull Request #10653 · PowerShell/PowerShell · GitHub

Add back newline for grouping with Format-Table and -Property - #10653

Merged
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:grouping-linebreak
Oct 2, 2019
Merged

Add back newline for grouping with Format-Table and -Property#10653
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:grouping-linebreak

Conversation

Steve Lee (SteveL-MSFT) commented Sep 30, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

When using Format-Table explicitly with -Property and -Grouping, it was missing a newline between the group and the content. Fix is to add back a newline after writing the grouping information. Also changed the default formatting of cert, registry, and files so that when there is grouping, it doesn't insert an extra newline (resulting in two). Because of the way formatting works, needed to remove use of the indent param and simply insert the indention into the resx string.

Before this change:

After this change:

dir with default table formatting is the same, but the changes were needed to keep them the same.

PR Context

Fix #9299

PR Checklist

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 1, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Oct 1, 2019

Andrew (anmenaga) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please add 'before change' and 'after change' screenshots to PR description?
When I'm trying this on 7.0.0-preview.3 I see missing newlines only when -Property is specified (in addition to -GroupBy), while PR reads like this should happen always when -GroupBy is used.

Steve Lee (SteveL-MSFT) changed the title Add back newline for grouping with Format-Table Add back newline for grouping with Format-Table and -Property Oct 2, 2019

Copy link
Copy Markdown
Member Author

Andrew (@anmenaga) updated title, description, and added screenshots. It only affects -Property

Andrew (anmenaga) merged commit 77ddec1 into PowerShell:master Oct 2, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delimiting lines have reduced or disappeared since version 6.2.0

3 participants


Back | FazBrowse Home | New Git URL