FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add -Delimiter to ConvertFrom-StringData by steviecoaster · Pull Request #10665 · PowerShell/PowerShell · GitHub

Add -Delimiter to ConvertFrom-StringData - #10665

Merged
Andrew (anmenaga) merged 10 commits into
PowerShell:masterfrom
steviecoaster:master
Oct 11, 2019
Merged

Add -Delimiter to ConvertFrom-StringData#10665
Andrew (anmenaga) merged 10 commits into
PowerShell:masterfrom
steviecoaster:master

Conversation

Stephen Valdinger (steviecoaster) commented Oct 1, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This PR adds the ability to specify a delimiter to the ConvertFrom-StringData cmdlet

PR Context

ConvertFrom-StringData is powerful, but not very discoverable. This addition eases usability of the cmdlet to work with many string formats easily.

PR Checklist

Ilya (iSazonov) left a comment
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add new tests and update existing tests.

You should sigh CLA before we can merge the PR.

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 9, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Oct 9, 2019

Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with two style comments.

Copy link
Copy Markdown

CI passed on rebuild.

Andrew (anmenaga) merged commit 6a807a2 into PowerShell:master Oct 11, 2019

Copy link
Copy Markdown
Collaborator

Nice work Stephen Valdinger (@steviecoaster)! 💖

Copy link
Copy Markdown
Collaborator

Stephen Valdinger (@steviecoaster) Thanks for your contribution!

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Copy link
Copy Markdown
Collaborator

chuanjiao10 Please open new issue with your feedback.

Ryan Yates (kilasuit) pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL