| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
don't color the whole line red making it harder to read
|
Is it common practice to paint in red only an error token and keep comment in white-on-black? |
Sorry, something went wrong.
|
Ilya (@iSazonov) the problem with that proposal is that some errors don't have a visible token, like foreach ($a 123) is missing in so nothing would be red. |
Sorry, something went wrong.
|
'^' could be red in the case. |
Sorry, something went wrong.
|
Just my opinion but ... some red is good to draw your attention ... too much text in red is hard to read / undesirable. Finding the sweet spot in between .... that's the challenge. :-) |
Sorry, something went wrong.
There was a problem hiding this comment.
nothing really blocking
I should have caught those other errors in the previous, sorry
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Remove unnecessary text before script path, detect if whole line is emphasized, then don't do any emphasis. Change emphasis color to accent color instead of error color to make it easier to read. Also fixed some typos and disabled strict mode in helper that works with different dynamic objects that puts errors in $error if strict mode is enabled.
Before:
After:
PR Context
Fix #10716
PR Checklist