FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update `ConciseView` to remove unnecessary text and not color entire line in red by SteveL-MSFT · Pull Request #10724 · PowerShell/PowerShell · GitHub

Update ConciseView to remove unnecessary text and not color entire line in red - #10724

Merged
Andrew (anmenaga) merged 4 commits into
PowerShell:masterfrom
SteveL-MSFT:erroview-update
Oct 8, 2019
Merged

Update ConciseView to remove unnecessary text and not color entire line in red#10724
Andrew (anmenaga) merged 4 commits into
PowerShell:masterfrom
SteveL-MSFT:erroview-update

Conversation

Steve Lee (SteveL-MSFT) commented Oct 7, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Remove unnecessary text before script path, detect if whole line is emphasized, then don't do any emphasis. Change emphasis color to accent color instead of error color to make it easier to read. Also fixed some typos and disabled strict mode in helper that works with different dynamic objects that puts errors in $error if strict mode is enabled.

Before:

After:

PR Context

Fix #10716

PR Checklist

don't color the whole line red making it harder to read

Copy link
Copy Markdown
Collaborator

Is it common practice to paint in red only an error token and keep comment in white-on-black?

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) the problem with that proposal is that some errors don't have a visible token, like foreach ($a 123) is missing in so nothing would be red.

Copy link
Copy Markdown
Collaborator

'^' could be red in the case.

Copy link
Copy Markdown
Collaborator

Just my opinion but ... some red is good to draw your attention ... too much text in red is hard to read / undesirable. Finding the sweet spot in between .... that's the challenge. :-)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nothing really blocking
I should have caught those other errors in the previous, sorry

Andrew (anmenaga) merged commit bce5b20 into PowerShell:master Oct 8, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Oct 9, 2019
Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 9, 2019
Ryan Yates (kilasuit) pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019
Steve Lee (SteveL-MSFT) deleted the erroview-update branch June 6, 2020 02:31
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConciseView for $ErrorView does not work in StrictMode

5 participants


Back | FazBrowse Home | New Git URL