Add `MacPorts` support to the build system · Pull Request #10736 · PowerShell/PowerShell · GitHub

PR Summary

Add MacPorts support to the build system

PR Context

MacPorts is one of the "Missing package managers for OS X".
The original build scripts only supported Homebrew and it is inadvised to have
both installed on a same system.
This change makes the build script use whatever package manager is currently
installed, or direct the user to download one of them if neither is present.
The build documentation has been updated to reflect that another package
manager is now also supported.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

MacPorts is one of the "Missing package managers for OS X". The original build scripts only supported Homebrew and it is inadvised to have both installed on a same system. This change makes the build script use whatever package manager is currently installed, or direct the user to download one of them if neither is present.

All CLA requirements met.

See comments

There is a spelling error.

Here is my function to test spelling.

function Test-Spelling
{
    param(
        [string[]]
        $Paths,
        [switch]
        $Fix

    )

    if(!(Get-Command mdspell -ErrorAction SilentlyContinue))
    {
        brew install yarn
        sudo yarn global add 'markdown-spellcheck@0.11.0'
    }

    $fileList = @()

    foreach($path in $Paths)
    {
        if($path -match '^\.[/\\]')
        {
            $fileList += ($path -replace '^\.[/\\]')
        }
        else {
            $fileList += $path
        }
    }

    $extraParams = @()

    if(!$Fix.IsPresent)
    {
        $extraParams += '--report'
    }

    Write-Verbose "Testing spelling for $fileList" -Verbose
    mdspell $fileList --ignore-numbers --ignore-acronyms @extraParams --en-us --no-suggestions
}

There is a spelling error.

The script only complains about the words "2.x" (referring to the required .net core version) and "MacPorts". Looks like false positives to me.

Spelling errors must be fixed for the PR to be accepted. Please run the tool and add the words to the dictionary. There is a fix switch in my script which will prompt you to add it to the dictionary

There was a random failure verifying a URL. I retried that task.

PoshChan-Bot (@PoshChan) Please remind me in 1 hour

Hold for compliance review

@Lucius-Q-User To explain what triggered the review, MacPorts license is not clearly declared on GitHub (image below). So, I'm waiting on a manual review of the use of this software in our project. They don't give me a specific ETA.

MacPro License

MIT License

Travis Plunk (@TravisEz13), this is the reminder you requested 1 hour ago

@Lucius-Q-User I'm monitoring the compliance review and I'd expect an answer within a week at this point. Ping me if we don't get an answer by that time.

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 8, 2019 18:43

Travis Plunk (TravisEz13) reviewed Oct 8, 2019

View reviewed changes

Comment thread build.psm1 Outdated

Travis Plunk (TravisEz13) requested changes Oct 8, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 8, 2019

Travis Plunk (TravisEz13) self-assigned this Oct 8, 2019

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 8, 2019

Alice added 2 commits October 8, 2019 23:07

Add word "MacPorts" to the spelling dictionary

5657096

Change the buildscript to not use Invoke-Expression

18c3158

Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 8, 2019

Travis Plunk (TravisEz13) added this to the 7.0.0-preview.5 milestone Oct 8, 2019

Travis Plunk (TravisEz13) requested changes Oct 8, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 8, 2019

Travis Plunk (TravisEz13) removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 8, 2019

Travis Plunk (TravisEz13) approved these changes Oct 9, 2019

View reviewed changes

Travis Plunk (TravisEz13) changed the title Add MacPorts support to the build system Add MacPorts support to the build system Oct 9, 2019

Travis Plunk (TravisEz13) merged commit 273b4ab into PowerShell:master Oct 9, 2019

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Add MacPorts support to the build system (PowerShell#10736 )

4386934

Add `MacPorts` support to the build system · Pull Request #10736 · PowerShell/PowerShell · GitHub

Uh oh!

Add MacPorts support to the build system - #10736

Add MacPorts support to the build system#10736Travis Plunk (TravisEz13) merged 3 commits intomasterPowerShell/PowerShell:masterfrom unknown repositoryCopy head branch name to clipboard

Conversation

Deleted user (ghost) commented Oct 8, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Oct 8, 2019

Uh oh!

Deleted user (ghost) commented Oct 8, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) commented Oct 8, 2019

Uh oh!

Travis Plunk (TravisEz13) commented Oct 8, 2019

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Oct 8, 2019

MacPro License

MIT License

Uh oh!

PoshChan-Bot (PoshChan) commented Oct 8, 2019

Uh oh!

Travis Plunk (TravisEz13) commented Oct 9, 2019

Uh oh!

Deleted user (ghost) commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add MacPorts support to the build system#10736
Travis Plunk (TravisEz13) merged 3 commits into
masterfrom
unknown repository

Deleted user (ghost) commented Oct 8, 2019 •
edited by ghost
Loading

Microsoft Contribution License Agreements (msftclas) commented Oct 8, 2019 •
edited
Loading

Deleted user (ghost) commented Oct 8, 2019 •
edited by ghost
Loading

Travis Plunk (TravisEz13) commented Oct 8, 2019 •
edited
Loading