FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Additional Microsoft Modules to track in PS7 Telemetry by SydneyhSmith · Pull Request #10751 · PowerShell/PowerShell · GitHub

Additional Microsoft Modules to track in PS7 Telemetry - #10751

Merged
Aditya Patwardhan (adityapatwardhan) merged 6 commits into
PowerShell:masterfrom
SydneyhSmith:master
Dec 11, 2019
Merged

Additional Microsoft Modules to track in PS7 Telemetry#10751
Aditya Patwardhan (adityapatwardhan) merged 6 commits into
PowerShell:masterfrom
SydneyhSmith:master

Conversation

Sydney Smith (SydneyhSmith) commented Oct 9, 2019
edited by SteveL-MSFT
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This adds additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.

PR Context

This allows us to better understand how PowerShell is being used to manage services and to better understand the types of PowerShell users based on which modules are loaded into PowerShell sessions.

PR Checklist

Adding additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.
Steve Lee (SteveL-MSFT) changed the title Additional Microsoft Modules to track in PS7 Telemetry WIP: Additional Microsoft Modules to track in PS7 Telemetry Oct 10, 2019
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 10, 2019
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 10, 2019
Updating to include non-gallery modules queried from Microsoft Docs.

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Joey Aiello (@joeyaiello) needs to review this list for accuracy

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 11, 2019

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) does this need to get in the RC?

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) yes

Joey Aiello (joeyaiello) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Whew. Finally got through this one.

We have lots of work to do in renaming Windows PowerShell modules in the Microsoft Docs, Sean Wheeler (@sdwheeler), I took some notes along the way.

"AzureRm.UsageAggregates",
"AzureRm.Websites",
"AzureRmStorageTable",
"AzureStorageTools",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not us, please remove

Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 4, 2019

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok from me once Joey Aiello (@joeyaiello) approves

Sydney Smith (SydneyhSmith) changed the title WIP: Additional Microsoft Modules to track in PS7 Telemetry Additional Microsoft Modules to track in PS7 Telemetry Dec 5, 2019

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) Joey Aiello (@joeyaiello) Please re-review.

Joey Aiello (joeyaiello) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the changes. Approving operating under the assumption that this list is not case sensitive (assuming that's what StringComparer.OrdinalIgnoreCase does, but I never can remember the exact behavior around ordinal vs. non-ordinal).

If it is case-sensitive, I have to make some more changes ASAP

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log MustHave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL