| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| } | ||
| finally | ||
| { | ||
| AmsiUtils.Uninitialize(); |
There was a problem hiding this comment.
Note: Uninitialize calls CloseSession internally.
Sorry, something went wrong.
There was a problem hiding this comment.
Please add this explanation and why we combine the tests to the file.
Sorry, something went wrong.
There was a problem hiding this comment.
I don't think the explanation is needed here. It's more confusing as you won't see the original test cases anymore.
Sorry, something went wrong.
|
I believe xUnit runs tests in random order and it looks like the previous implementation depended on some ordering, so this might be the fix |
Sorry, something went wrong.
There was a problem hiding this comment.
With one minor comment.
Sorry, something went wrong.
|
I will merge this PR to unblock CI failures. |
Sorry, something went wrong.
|
🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
The event handler test is failing intermittently in our daily test run:
https://powershell.visualstudio.com/PowerShell/_build/results?buildId=35039
The cause of it is likely the SecuritySupportTests, where the registration/unregistration of the event handler are separately in two tests.
I merge those 3 tests into one and will see if that resolves the intermittent failure.
Also slightly update Start-PSBuild to make -SMAOnly literally only re-build and re-deploy S.M.A.dll, without doing extra post-build tasks.
The main purpose of this change is to avoid spinning up the pwsh for retrieving experimental features, so that we can add code in S.M.A.dll to wait for debugger to attach for debugging scenarios. /cc Rob Holt (@rjmholt)
PR Checklist