FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix stringdata test to correctly validate keys of hashtables by SteveL-MSFT · Pull Request #10810 · PowerShell/PowerShell · GitHub

Fix stringdata test to correctly validate keys of hashtables - #10810

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:stringdata-test
Oct 23, 2019
Merged

Fix stringdata test to correctly validate keys of hashtables#10810
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:stringdata-test

Conversation

Steve Lee (SteveL-MSFT) commented Oct 16, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

The previous test wasn't correctly validating the keys in the hashtable match expected and actual. Fix is to update the test cases so the expected hashtable has the right key names and remove the unnecessary foreach loop (since we know the hashtable only has one entry) and verify the key and the value.

PR Context

PR Checklist

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Please rebase to pass CI-Windows.

Ilya (iSazonov) added the WG-Quality-Test issues in a test or in test infrastructure label Oct 23, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.5 milestone Oct 23, 2019
Ilya (iSazonov) added CL-Test Indicates that a PR should be marked as a test change in the Change Log and removed WG-Quality-Test issues in a test or in test infrastructure labels Oct 23, 2019
Ilya (iSazonov) merged commit 90fb1ea into PowerShell:master Oct 23, 2019

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Steve Lee (SteveL-MSFT) deleted the stringdata-test branch June 6, 2020 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL