| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
PoshChan-Bot (@PoshChan) please retry windows |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-Windows |
Sorry, something went wrong.
get-error outputtype is errorrecord and exception fix formatting that wasn't handling parse exceptions correctly update tests to check typenames
|
PoshChan-Bot (@PoshChan) please retry static |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-static-analysis |
Sorry, something went wrong.
There was a problem hiding this comment.
I think you have a typo in there
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT) Do you want to get approve from anybody? |
Sorry, something went wrong.
|
James Truher (@JamesWTruher) can you review? |
Sorry, something went wrong.
|
Up. |
Sorry, something went wrong.
There was a problem hiding this comment.
just a couple questions
Sorry, something went wrong.
…10856) - Added OutputType attribute. - Cmdlet adds the PSExtendedError typename and removes Exception and ErrorRecord typenames so that the formatting is used. The formatter then removes PSExtendedError and puts back the original typename so that $Error should be the same before calling Get-Error. - While testing, had to make some changes to how InvocationInfo is retrieved so that ParseException which contains a nested ErrorRecord which as InvocationInfo is handled correctly. - Combined Exception and ErrorRecord formatter into one.
|
🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
…owerShell#10856) - Added OutputType attribute. - Cmdlet adds the PSExtendedError typename and removes Exception and ErrorRecord typenames so that the formatting is used. The formatter then removes PSExtendedError and puts back the original typename so that $Error should be the same before calling Get-Error. - While testing, had to make some changes to how InvocationInfo is retrieved so that ParseException which contains a nested ErrorRecord which as InvocationInfo is handled correctly. - Combined Exception and ErrorRecord formatter into one.
| Back | FazBrowse Home | New Git URL |
PR Summary
Cmdlet was missing declaring OutputType which is ErrorRecord#PSExtendedError and Exception#PSExtendedError. Added OutputType attribute. Cmdlet adds the PSExtendedError typename and removes Exception and ErrorRecord typenames so that the formatting is used. The formatter then removes PSExtendedError and puts back the original typename so that $Error should be the same before calling Get-Error. While testing, had to make some changes to how InvocationInfo is retrieved so that ParseException which contains a nested ErrorRecord which as InvocationInfo is handled correctly. Combined Exception and ErrorRecord formatter into one.
PR Checklist