FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix to Select-String emphasis and Import-DscResource in CHANGELOG.md by joeyaiello · Pull Request #10890 · PowerShell/PowerShell · GitHub

Fix to Select-String emphasis and Import-DscResource in CHANGELOG.md - #10890

Merged
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
joeyaiello:ChangelogFix
Oct 29, 2019
Merged

Fix to Select-String emphasis and Import-DscResource in CHANGELOG.md#10890
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
joeyaiello:ChangelogFix

Conversation

Joey Aiello (joeyaiello) commented Oct 25, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Two changelog tweaks:

  • one to fix an incorrect line about Select-String in 7.0-preview.5
  • one to reword a confusing sentence about Import-DscResource

PR Context

The changelog incorrectly stated that Select-String got an -Emphasis parameter, when in fact emphasis is default and a -NoEmphasis param was added.

Also, Steve Lee (@SteveL-MSFT) had been pinged about a confusing line about Import-DscResource, so I went ahead and reworded it as well.

PR Checklist

Copy link
Copy Markdown
Contributor Author

Also, I'm happy to make the direct edit in the tag after this is approved and merged, so we don't have to retag anything.

Comment thread CHANGELOG.md Outdated
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 25, 2019
Co-Authored-By: Steve Lee <slee@microsoft.com>
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 29, 2019
Andrew (anmenaga) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Oct 29, 2019
Andrew (anmenaga) merged commit 7f01d1c into PowerShell:master Oct 29, 2019

Copy link
Copy Markdown
Member

Updated the preview.5 release notes.

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL