FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add back `Out-Printer` command by SteveL-MSFT · Pull Request #10906 · PowerShell/PowerShell · GitHub

Add back Out-Printer command - #10906

Merged
Aditya Patwardhan (adityapatwardhan) merged 8 commits into
PowerShell:masterfrom
SteveL-MSFT:out-printer
Nov 1, 2019
Merged

Add back Out-Printer command#10906
Aditya Patwardhan (adityapatwardhan) merged 8 commits into
PowerShell:masterfrom
SteveL-MSFT:out-printer

Conversation

Steve Lee (SteveL-MSFT) commented Oct 26, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

System System.Drawing is back, we can re-enable Out-Printer command. Manually validated using Out-Printer to pdf printer.

PR Context

Fix #10660

PR Checklist

Steve Lee (SteveL-MSFT) added Review - Committee The PR/Issue needs a review from the PowerShell Committee Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Oct 28, 2019

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) The new FWLink for Out-Printer is https://go.microsoft.com/fwlink/?LinkID=2109553

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry static

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT), successfully started retry of PowerShell-CI-static-analysis

Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with two minor comments.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please respond to comments from Ilya (@iSazonov). Otherwise looks good.

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) Please resolve merge conflicts

Copy link
Copy Markdown
Member Author

I'll wait for GraphicalHost to be merged first as there will be another merge conflict

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) Graphical host is merged. Please resolve merge conflict.

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) please remind me in 1 hour.

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan), this is the reminder you requested 1 hour. ago

Aditya Patwardhan (adityapatwardhan) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 1, 2019
Aditya Patwardhan (adityapatwardhan) merged commit 6882ad5 into PowerShell:master Nov 1, 2019
Steve Lee (SteveL-MSFT) deleted the out-printer branch November 1, 2019 18:46

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

ghost mentioned this pull request Nov 21, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring back Out-Printer

5 participants


Back | FazBrowse Home | New Git URL