| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Sean Wheeler (@sdwheeler) new fwlink for Get-Counter? |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT) https://go.microsoft.com/fwlink/?linkid=2109647
|
Sorry, something went wrong.
There was a problem hiding this comment.
I found https://github.com/microsoft/Tx. It seems work with blg.
Sorry, something went wrong.
|
Ilya (@iSazonov) nice find, seems that Tx is using a different set of APIs to read the log, not sure if there is a different public api to write the binary log. I suggest we defer this for now. |
Sorry, something went wrong.
Maybe open a tracking issue if you plan to investigate this? |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT) Can you run a coordinated package build and send me a Direct Message with the build information? Let's verify this doesn't cause any new compliance issues. |
Sorry, something went wrong.
|
🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Reviewed the APIs being used. Get-Counter can work with just public APIs published in pdh.h. Import-Counter and Export-Counter rely on undocumented APIs so those are removed. The PDH apis are really old so I don't believe there's any chance to get those APIs or the binary log format documented so removed that code. Get-Counter -ListSet has Description property as empty because it isn't supported by PDH apis.
PR Checklist