FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle case where Host may not return Rows or Cols of screen by SteveL-MSFT · Pull Request #10938 · PowerShell/PowerShell · GitHub

Handle case where Host may not return Rows or Cols of screen - #10938

Merged
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:format-table-remoting
Oct 30, 2019
Merged

Handle case where Host may not return Rows or Cols of screen#10938
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:format-table-remoting

Conversation

Steve Lee (SteveL-MSFT) commented Oct 29, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

In the case where the Host doesn't implement WindowSize so that Rows and Cols can be returned, this is handled locally. But if used over interactive remote session, the remoting layer throws a remoting exception. To handle this case, catch any exception trying to retrieve those values and use a default value so that formatting still renders. The previous fix for this was too specific in the Exceptions caught that it didn't catch a remoting Exception.

PR Checklist

Steve Lee (SteveL-MSFT) changed the title Handle case where Host may not return Rows or Cols of screen WIP: Handle case where Host may not return Rows or Cols of screen Oct 29, 2019
Steve Lee (SteveL-MSFT) changed the title WIP: Handle case where Host may not return Rows or Cols of screen Handle case where Host may not return Rows or Cols of screen Oct 30, 2019
Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 30, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Oct 30, 2019
Andrew (anmenaga) merged commit 00f41a7 into PowerShell:master Oct 30, 2019
Steve Lee (SteveL-MSFT) deleted the format-table-remoting branch October 30, 2019 19:57

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL