| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This PR might impact tooling, because it might be necessary to debug a module imported via compat. |
Sorry, something went wrong.
Given that this is to be a builtin feature, the user experience might be better if encapsulated: Invoke-InWinPSCompatibilitySession { Get-WinPSLiveObject | Set-WinPSLiveObject } |
Sorry, something went wrong.
@alexbuzzbee could you expand on this with an example? What scenario are you envisaging here? Also, it might be best to have this discussion in the RFC. |
Sorry, something went wrong.
|
Say you have a script module that was written as Windows-specific (because it uses Windows P/Invokes, COM, or Windows-specific .NET APIs), but need to use it in a modern script. A problem is happening inside the Windows-specific module. You need to debug inside it, so the debugging tools need to be able to see and work inside the Windows PowerShell compat session. Yes, it might be possible to reproduce the issue using a Windows PowerShell script instead, but that would usually be significantly more effort than just debugging the module. It might be correct that this should go in the RFC; I was just going off the tooling checkboxes and noted that they might not be accurately filled. |
Sorry, something went wrong.
|
Andrew (@anmenaga) All I was trying to point out is that the "I have considered the user experience from a tooling perspective and enumerated concerns in the summary" box should probably be checked instead of "I have considered the user experience from a tooling perspective and don't believe tooling will be impacted." |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Andrew (@anmenaga) Is this PR ready for review? If so, please remove the WIP: prefix from the title so we can pull in more reviewers. |
Sorry, something went wrong.
There was a problem hiding this comment.
telemetry changes look good
Sorry, something went wrong.
| "Alias", "nsn", "New-PSSession", $($FullCLR -or $CoreWindows -or $CoreUnix), "", "", "" | ||
| "Alias", "nv", "New-Variable", $($FullCLR -or $CoreWindows -or $CoreUnix), "ReadOnly", "", "" | ||
| "Alias", "nwsn", "New-PSWorkflowSession", $($FullCLR ), "ReadOnly", "", "" | ||
| "Alias", "nwsn", "New-PSWorkflowSession", $($FullCLR -or $CoreWindows ), "", "", "" |
There was a problem hiding this comment.
Why do we need the change?
Sorry, something went wrong.
There was a problem hiding this comment.
this alias comes from PSWorkflow module which is incompartible with PS Core.
This test just loads all stuff from a hardcoded set of modules and checks against this huge table; PSWorkflow is one of them. With this PR module can actually be successfully loaded on PS Core and the alias shows up, and the test did not expect this.
Sorry, something went wrong.
There was a problem hiding this comment.
DefaultCommands.Tests is designed to tracking that is explicitly in PowerShell Core on different platforms and show difference from Windows PowerShell.
If the test failed I guess it is side effect from other tests and just the tests must do right cleanup.
Sorry, something went wrong.
|
Andrew (@anmenaga) Can you please resolve the conflict, again :) |
Sorry, something went wrong.
|
🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Implementation for 'Importing Windows PowerShell modules in PowerShell Core' RFC.
Example:

PR Context
PR Checklist