Fix style issues by iSazonov · Pull Request #10998 · PowerShell/PowerShell · GitHub

PR Summary

Fix style issues that appeared in the last month.
Easy review commit by commit.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Ilya (@iSazonov), your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By CustomPipeName.Can enter, exit, and re-enter using CustomPipeName

Expected $true, because The script was able to re-enter another process and grab the pipe of '4fzpekvk.ydv'., but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 170
170:                     Should -BeTrue -Because "The script was able to re-enter another process and grab the pipe of '$pipeName'."

Extra whitespace?

Fixed.

Extra whitespace?

Fixed.

13/50 reviewed

Travis Plunk (@TravisEz13) it's easier to review by commit than by file since the changes are similar per commit

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Ilya (iSazonov) added 7 commits November 6, 2019 10:52

Fix ast.cs

6bcdbc3

Fix Parser.cs

d4dfe4a

Fix MiscOps.cs

78eb4c6

Fix TestExe.cs

6dc4c50

Fix breakpoints docs

432bd55

Fix TypeTable.cs

b06b585

Fix Clipboard.cs

930304b

Ilya (iSazonov) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 6, 2019 09:14

Fix TypeTable.cs 2

88e577b

PoshChan-Bot (PoshChan) reviewed Nov 6, 2019

View reviewed changes

Ilya (iSazonov) added 7 commits November 6, 2019 14:47

Set final dot in doc comments

3aa73cb

Set dot before </param>

564c798

Set upper case in <param>

b184d72

Set final dot in doc comments 2

cc008c5

Set dot before </return>

973f1ae

Set upper case in <returns>

4033ad2

Other doc fixes

286cab2

Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) November 6, 2019 11:24

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 6, 2019

Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Nov 6, 2019

Steve Lee (SteveL-MSFT) requested changes Nov 6, 2019

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 6, 2019

Travis Plunk (TravisEz13) reviewed Nov 6, 2019

View reviewed changes

Travis Plunk (TravisEz13) changed the title Fix October month style issues Fix style issues Nov 6, 2019

Address feedback

cad2632

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 7, 2019

Steve Lee (SteveL-MSFT) approved these changes Nov 7, 2019

View reviewed changes

Aditya Patwardhan (adityapatwardhan) approved these changes Nov 7, 2019

View reviewed changes

Aditya Patwardhan (adityapatwardhan) self-assigned this Nov 7, 2019

Aditya Patwardhan (adityapatwardhan) merged commit 9851b07 into PowerShell:master Nov 7, 2019

Ilya (iSazonov) deleted the fix-month-style-2 branch November 8, 2019 03:07

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Fix style issues (PowerShell#10998 )

70d7a42

Fix style issues by iSazonov · Pull Request #10998 · PowerShell/PowerShell · GitHub

Uh oh!

Fix style issues - #10998

Fix style issues#10998
Aditya Patwardhan (adityapatwardhan) merged 16 commits into
PowerShell:masterfrom
iSazonov:fix-month-style-2

Ilya (iSazonov) commented Nov 6, 2019 •
edited
Loading

Uh oh!

Uh oh!

PoshChan-Bot (PoshChan) Nov 6, 2019

Uh oh!

Steve Lee (SteveL-MSFT) Nov 6, 2019

Uh oh!

Ilya (iSazonov) Nov 7, 2019

Uh oh!

Steve Lee (SteveL-MSFT) Nov 6, 2019

Uh oh!

Ilya (iSazonov) Nov 7, 2019

Uh oh!

Travis Plunk (TravisEz13) left a comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 7, 2019 •
edited
Loading

Uh oh!

Uh oh!

Deleted user (ghost) commented Nov 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -19,7 +19,7 @@ internal static class Clipboard
		private static string StartProcess(

                   {
                       /// <summary>
-                      /// Construct a new chainable AST with the given extent.
+                      ///  Initializes a new instance of the new chainable AST with the given extent.

                   {
                       /// <summary>
-                      /// Create a new statement chain AST from two statements and an operator.
+                      ///  Initializes a new instance of the new statement chain AST from two statements and an operator.

Fix style issues by iSazonov · Pull Request #10998 · PowerShell/PowerShell · GitHub

Uh oh!

Fix style issues - #10998

Fix style issues#10998Aditya Patwardhan (adityapatwardhan) merged 16 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom iSazonov:fix-month-style-2iSazonov/PowerShell:fix-month-style-2Copy head branch name to clipboard

Conversation

Ilya (iSazonov) commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

PoshChan-Bot (PoshChan) Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Nov 7, 2019

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Nov 7, 2019

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deleted user (ghost) commented Nov 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix style issues#10998
Aditya Patwardhan (adityapatwardhan) merged 16 commits into
PowerShell:masterfrom
iSazonov:fix-month-style-2

Ilya (iSazonov) commented Nov 6, 2019 •
edited
Loading

Steve Lee (SteveL-MSFT) commented Nov 7, 2019 •
edited
Loading