FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Review currentculture by iSazonov · Pull Request #11044 · PowerShell/PowerShell · GitHub

Review currentculture - #11044

Merged
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
iSazonov:review-currentculture
Nov 22, 2019
Merged

Review currentculture#11044
Ilya (iSazonov) merged 6 commits into
PowerShell:masterfrom
iSazonov:review-currentculture

Conversation

Ilya (iSazonov) commented Nov 12, 2019
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Related #8064

Replace StringComparison.CurrentCulture with StringComparison.Ordinal where it is used without the need.

PR Context

PR Checklist

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 12, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Nov 12, 2019
Ilya (iSazonov) self-assigned this Nov 12, 2019

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Ilya (iSazonov) merged commit c17d5a7 into PowerShell:master Nov 22, 2019
Ilya (iSazonov) deleted the review-currentculture branch November 22, 2019 03:37

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Replace StringComparison.CurrentCulture with StringComparison.Ordinal where it is used without the need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL