FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add default for SDKToUse so that solution builds in Visual Studio by SteveL-MSFT · Pull Request #11085 · PowerShell/PowerShell · GitHub

Add default for SDKToUse so that solution builds in Visual Studio - #11085

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:visualstudio-build
Nov 16, 2019
Merged

Add default for SDKToUse so that solution builds in Visual Studio#11085
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:visualstudio-build

Conversation

Steve Lee (SteveL-MSFT) commented Nov 15, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

build.psm1 was updated awhile back to conditional build with and without WindowsDesktop SDK depending on target. Since this is only defined in build.psm1, it doesn't build in VisualStudio using the solution file. Fix is to add in powershell-win-core project file to define SDKToUse to default to WindowsDesktop SDK if it isn't already defined.

PR Checklist

Christoph Bergmeister (bergmeister) commented Nov 17, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks, I haven't had the time to test it yet but it is very appreciated that the team tries to keep the VS support as quite a few community members like me, Staffan and others like to use VS for some code navigation/debugging where vs-code sometimes is too simplistic or lacks some of the enhanced features of VS (despite VS being a bit more heavy)

Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Nov 18, 2019
Ilya (iSazonov) added this to the 7.0.0-preview.6 milestone Nov 18, 2019
Steve Lee (SteveL-MSFT) deleted the visualstudio-build branch November 18, 2019 20:44

Copy link
Copy Markdown

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL