FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use async streams in Invoke-RestMethod by iSazonov · Pull Request #11095 · PowerShell/PowerShell · GitHub

Use async streams in Invoke-RestMethod - #11095

Merged
Ilya (iSazonov) merged 9 commits into
PowerShell:masterfrom
iSazonov:invoke-rest-pipe
Mar 18, 2020
Merged

Use async streams in Invoke-RestMethod#11095
Ilya (iSazonov) merged 9 commits into
PowerShell:masterfrom
iSazonov:invoke-rest-pipe

Conversation

Ilya (iSazonov) commented Nov 17, 2019
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Fix #4129

  • Use async stream methods in Invoke-RestMethod to save a large file (> 2Gb) to output file as binary
  • Now we can interrupt downloading large file by Ctrl-C
  • Now output file is readable at download time and we can see a size of the file

PR Context

PR Checklist

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 18, 2019
Ilya (iSazonov) marked this pull request as ready for review November 18, 2019 07:19

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Dongbo Wang (@daxian-dbw) Have you any comments about the PR or we can merge?

Copy link
Copy Markdown
Member

Ilya (@iSazonov) I trust Aditya Patwardhan (@adityapatwardhan) on this one

Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking, more comments may be coming

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 29, 2020
ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 29, 2020
ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 31, 2020

Copy link
Copy Markdown
Collaborator Author

Dongbo Wang (@daxian-dbw) Please continue your review.

Ilya (iSazonov) merged commit 8ebff6a into PowerShell:master Mar 18, 2020
Ilya (iSazonov) deleted the invoke-rest-pipe branch March 18, 2020 13:40

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invoke-RestMethod fails on very large files

6 participants


Back | FazBrowse Home | New Git URL