FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make update notification support LTS and default channels by daxian-dbw · Pull Request #11132 · PowerShell/PowerShell · GitHub

Make update notification support LTS and default channels - #11132

Merged
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
daxian-dbw:update
Dec 10, 2019
Merged

Make update notification support LTS and default channels#11132
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
daxian-dbw:update

Conversation

Dongbo Wang (daxian-dbw) commented Nov 20, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Update the feature to support the notification type that can be configured using the environment variable POWERSHELL_UPDATECHECK.
This is to address the feedback from powershell committee in the RFC review: PowerShell/PowerShell-RFC#162 (comment), quoted below:

Coming out of @PowerShell/powershell-committee review, we want to change the environment variable to no longer be a simple opt-out/in but rather a field that can be used to set the "channel". So e.g. a $env:PSNotificationPreference that can be set to Default, Off, or LTS, where the latter would only provide LTS update notifications in their notifications.

POWERSHELL_UPDATECHECK accepts 3 values: Off, Default, and LTS (case-insensitive), and the behavior is as follows:

  • Off: turn off the udpate notification.
  • Default: give you the default behaviors
    • the preview version 'pwsh' checks for the new preview version and the new GA version.
    • the GA version 'pwsh' checks for the new GA version only.
  • LTS: both preview and GA version 'pwsh' checks for the new LTS version only.

For a specific version of pwsh and a specific notification type, only one update check task, at most, will run to complete per a day. Other tasks should be able to detect "a check is in progress" or "the check has been done for today" and bail out early, to avoid any unnecessary network IO or CPU cycles.

Note that this is a breaking change comparing to preview-5 and preview-6, because the environment variable name and its accepted values are changed.

PR Context

PR Checklist

Dongbo Wang (daxian-dbw) added the CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log label Nov 21, 2019
Dongbo Wang (daxian-dbw) added this to the 7.0-Consider milestone Nov 21, 2019

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry windows

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), successfully started retry of PowerShell-CI-Windows

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry windows

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), successfully started retry of PowerShell-CI-Windows

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry windows

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), successfully started retry of PowerShell-CI-Windows

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) I think this PR is ready to be merged.

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL