Add `Unblock-File` for macOS by TravisEz13 · Pull Request #11137 · PowerShell/PowerShell · GitHub

PR Summary

Add Unblock-File for macOS

PR Context

Adds a viable workaround for #10874, not just for our package but for other packages.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed: Document that Unblock-File now works on macOS MicrosoftDocs/PowerShell-Docs#5148
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Co-Authored-By: Steve Lee <slee@microsoft.com> Co-Authored-By: Ilya <darpa@yandex.ru>

Please use named parameters.

nit: spaces after ,

maybe this should be System.PlatformNotSupportedException

definitely not, we are on a supported platform here.

maybe you meant line 142... changed it there.

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

code for unblock-file on macOS

31be778

Travis Plunk (TravisEz13) requested a review from Steve Lee (SteveL-MSFT) November 20, 2019 19:42

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

Add and update tests

a98e089

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

fix linux tests

ef87a3d

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

Travis Plunk (TravisEz13) added 4 commits November 20, 2019 13:55

fix unimplemented test

088dd3b

make unblock not fail if already unblocked

ad12b34

Get rid of code to get value string of attribute

7823022

enable pending test

a3c7d80

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

Combine macOS and Windows tests

8adccdc

PoshChan-Bot (PoshChan) reviewed Nov 20, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

Ilya (iSazonov) reviewed Nov 21, 2019

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs Outdated

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs

Steve Lee (SteveL-MSFT) requested changes Nov 21, 2019

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 21, 2019

Travis Plunk (TravisEz13) and others added 4 commits November 21, 2019 11:36

Apply suggestions from code review

9f16948

Co-Authored-By: Steve Lee <slee@microsoft.com> Co-Authored-By: Ilya <darpa@yandex.ru>

remove unused code

760aa10

format if statement

d4f9392

fix build break

da3da7c

Steve Lee (SteveL-MSFT) approved these changes Nov 22, 2019

View reviewed changes

Travis Plunk (TravisEz13) marked this pull request as ready for review November 22, 2019 21:49

Travis Plunk (TravisEz13) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 22, 2019

Travis Plunk (TravisEz13) added this to the rc.1-consider milestone Nov 22, 2019

Travis Plunk (TravisEz13) mentioned this pull request Nov 22, 2019

Document that Unblock-File now works on macOS MicrosoftDocs/PowerShell-Docs#5148

Closed

10 tasks

Travis Plunk (TravisEz13) assigned Aditya Patwardhan (adityapatwardhan) Nov 22, 2019

Aditya Patwardhan (adityapatwardhan) requested changes Dec 2, 2019

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 2, 2019

Address PR comments

d7c5a17

Aditya Patwardhan (adityapatwardhan) approved these changes Dec 3, 2019

View reviewed changes

Travis Plunk (TravisEz13) merged commit 3cdab0d into PowerShell:master Dec 3, 2019

Travis Plunk (TravisEz13) deleted the unblock branch December 3, 2019 01:51

Travis Plunk (TravisEz13) modified the milestones: rc.1-consider, rc.1-approved Dec 4, 2019

Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 4, 2019

Add Unblock-File for macOS (#11137 )

9bb1504

Travis Plunk (TravisEz13) modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 4, 2019

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Add Unblock-File for macOS (PowerShell#11137 )

321a3ec

+                          {
+                              string errorMessage = UnblockFileStrings.LinuxNotSupported;
+                              Exception e = new NotImplementedException(errorMessage);
+                              ThrowTerminatingError(new ErrorRecord(e, "LinuxNotSupported", ErrorCategory.NotImplemented, null));

+                          {
+                              if(IsBlocked(path))
+                              {
+                                  UInt32 result = RemoveXattr(path,MacBlockAttribute,RemovexattrFollowSymLink);

+                                  {
+                                      string errorMessage = string.Format(CultureInfo.CurrentUICulture, UnblockFileStrings.UnblockError, path);
+                                      Exception e = new InvalidOperationException(errorMessage);
+                                      WriteError(new ErrorRecord(e, "UnblockError", ErrorCategory.InvalidResult,path));

Add `Unblock-File` for macOS by TravisEz13 · Pull Request #11137 · PowerShell/PowerShell · GitHub

Uh oh!

Add Unblock-File for macOS - #11137

Add Unblock-File for macOS#11137Travis Plunk (TravisEz13) merged 13 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom TravisEz13:unblockTravisEz13/PowerShell:unblockCopy head branch name to clipboard

Conversation

Travis Plunk (TravisEz13) commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

Deleted user (ghost) commented Dec 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add Unblock-File for macOS#11137
Travis Plunk (TravisEz13) merged 13 commits into
PowerShell:masterfrom
TravisEz13:unblock

Travis Plunk (TravisEz13) commented Nov 20, 2019 •
edited
Loading