FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc. by brendandburns · Pull Request #11155 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc. - #11155

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
brendandburns:better
Nov 26, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc.#11155
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
brendandburns:better

Conversation

Brendan Burns (brendandburns) commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Improve detection of Ubuntu-based systems

PR Context

There are lots of Ubuntu deriviatives out there, but they all are based on Ubuntu and thus supported by this script. Improve detection of such distros using the lsb_release tool.

PR Checklist

Travis Plunk (TravisEz13) reviewed Nov 22, 2019
View reviewed changes
Comment thread build.psm1 Outdated
Travis Plunk (TravisEz13) requested changes Nov 22, 2019
View reviewed changes

Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

see comments

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 22, 2019
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 25, 2019

Brendan Burns (brendandburns) commented Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

Comment addressed. Please re-check.

Brendan Burns (brendandburns) commented Nov 26, 2019

Copy link
Copy Markdown
Contributor Author

fwiw, the CodeFactor failures don't appear to be related to this change. Do I need to rebase?

Steve Lee (SteveL-MSFT) commented Nov 26, 2019

Copy link
Copy Markdown
Member

brendanburns CodeFactor isn't a merge blocker. Since you looked at the failures and they are not related to your change, you can ignore. Looks good, thanks for your contribution!

Travis Plunk (TravisEz13) merged commit 2a76aa1 into PowerShell:master Nov 26, 2019
Dongbo Wang (daxian-dbw) added this to the GA-approved milestone Jan 9, 2020
Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 9, 2020
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Jan 10, 2020
Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc (#…
d45b77f 
…11155)

Deleted user (ghost) commented Jan 16, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Improve Ubuntu detection for Ubuntu derivatives like GalliumOS etc (P…
a4d7e3c 
…owerShell#11155)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Travis Plunk (TravisEz13) TravisEz13 approved these changes
Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
Andrew (anmenaga) Awaiting requested review from anmenaga
Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL