FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix regression in Get-PSCallStack by iSazonov · Pull Request #11210 · PowerShell/PowerShell · GitHub

Fix regression in Get-PSCallStack - #11210

Merged
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
iSazonov:fix-typetable-emptystring
Dec 2, 2019
Merged

Fix regression in Get-PSCallStack#11210
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
iSazonov:fix-typetable-emptystring

Conversation

Ilya (iSazonov) commented Nov 28, 2019
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Fix #11208

PR Context

The regression comes from #6950

PR Checklist

Ilya (iSazonov) force-pushed the fix-typetable-emptystring branch from afc3e2b to 6e5daaa Compare November 28, 2019 07:53
}

It "Get-PSCallStack returns Arguments" {
& { (Get-PSCallStack)[0].Arguments } 'foo' | Should -Match 'foo'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please also add a test for the case where the scriptblock has formal parameters:

 & { param ($x)  (Get-PSCallStack)[0].Arguments } 'foo' 

and another where multiple arguments are passed to the scriptblock:

 & { (Get-PSCallStack)[0].Arguments } 'foo'  'bar'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Aditya Patwardhan (adityapatwardhan) merged commit 2ee1760 into PowerShell:master Dec 2, 2019
Ilya (iSazonov) deleted the fix-typetable-emptystring branch December 3, 2019 03:20
Travis Plunk (TravisEz13) removed this from the rc.1-consider milestone Dec 4, 2019

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get-PSCallStack's Arguments script property contains no useful information

7 participants


Back | FazBrowse Home | New Git URL