FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 by daxian-dbw · Pull Request #11258 · PowerShell/PowerShell · GitHub

Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 - #11258

Merged
Aditya Patwardhan (adityapatwardhan) merged 5 commits into
PowerShell:masterfrom
daxian-dbw:firstordefault
Dec 11, 2019
Merged

Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1#11258
Aditya Patwardhan (adityapatwardhan) merged 5 commits into
PowerShell:masterfrom
daxian-dbw:firstordefault

Conversation

Dongbo Wang (daxian-dbw) commented Dec 3, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Fix #10554

Hidden members should not be returned by any fuzzy searches, such as searching by 'match' or enumerating the collection. They are returned only if the member names are explicitly looked for. FirstOrDefault is a fuzzy search, so it should ignore the hidden members.

PR Context

PR Checklist

Dongbo Wang (daxian-dbw) changed the title Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in PowerShell 7 preview Fix a regression in formatting caused by the 'FirstOrDefault' primitive added in 7.0.0-Preview1 Dec 3, 2019
Dongbo Wang (daxian-dbw) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 3, 2019
Dongbo Wang (daxian-dbw) added this to the rc.1-consider milestone Dec 3, 2019

Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with one minor comment.

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

Describe 'Bug fixes related to formatting' -Tag CI {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it is better to have positive and functional names for the file and describe.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated the test name, but kept the file name unchanged. I would like this file to be used for future bug fixes related to formatting.

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write-Output of class with hidden params regression in PS 7

6 participants


Back | FazBrowse Home | New Git URL