FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improvements in breakpoint APIs for remote scenarios by TylerLeonhardt · Pull Request #11312 · PowerShell/PowerShell · GitHub

Improvements in breakpoint APIs for remote scenarios - #11312

Merged
Aditya Patwardhan (adityapatwardhan) merged 15 commits into
PowerShell:masterfrom
TylerLeonhardt:improve-breakpoint-apis
Dec 13, 2019
Merged

Improvements in breakpoint APIs for remote scenarios#11312
Aditya Patwardhan (adityapatwardhan) merged 15 commits into
PowerShell:masterfrom
TylerLeonhardt:improve-breakpoint-apis

Conversation

TylerLeonhardt commented Dec 10, 2019
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

This addresses two things:

  • gives the ability to set a breakpoint remotely on a runspace even if it's busy
  • gives the ability to set a breakpoint on a specific runspace

This is only added to the API surface for the PowerShell extension. In theory the breakpoint cmdlets can take advantage of this in the future.

PR Context

This will light up a scenario in the PowerShell Editor Services so that when you click to add a breakpoint, that breakpoint will be applied even if the PowerShell Integrated Console is busy running the Debug-Runspace.

PR Checklist

Copy link
Copy Markdown
Member Author

The "hook in output" commit hooks up the ability to send output to the original client PowerShell without needing to invoke a pipeline on the server side.

TylerLeonhardt changed the title WIP: Improvements in breakpoint APIs for remote scenarios Improvements in breakpoint APIs for remote scenarios Dec 11, 2019
TylerLeonhardt marked this pull request as ready for review December 11, 2019 17:45
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2019
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2019
Aditya Patwardhan (adityapatwardhan) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 11, 2019

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry PowerShell-CI-static-analysis

Copy link
Copy Markdown
Collaborator

TylerLeonhardt, I do not understand the build target(s) PowerShell-CI-static-analysis; I only allow static, windows, macos, linux, all

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry static

Copy link
Copy Markdown
Collaborator

TylerLeonhardt, successfully started retry of PowerShell-CI-static-analysis

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry static

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) please retry windows

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) - please update your review

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 12, 2019

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) - please re-review

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL