FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Nuget package signing for Coordinated Package build by PaulHigin · Pull Request #11316 · PowerShell/PowerShell · GitHub

Fix Nuget package signing for Coordinated Package build - #11316

Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
PaulHigin:fix-nugetpackage-signing
Dec 10, 2019
Merged

Fix Nuget package signing for Coordinated Package build#11316
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
PaulHigin:fix-nugetpackage-signing

Conversation

Copy link
Copy Markdown
Contributor

PR Summary

This PR fixes Coordinated Packages build failure by updating nuget build yml to perform signing for scheduled builds via SHOULD_SIGN variable.

PR Context

PR Checklist

outPathRoot: '$(System.ArtifactsDirectory)\signed'
binVersion: $(SigingVersion)
binVersionOverride: $(SigningVersionOverride)
condition: and(succeeded(), eq(variables['SHOULD_SIGN'], 'true'))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just curious, where is this variable defined?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It get defined by calling the template in line 60

Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 10, 2019
Aditya Patwardhan (adityapatwardhan) merged commit 32e2198 into PowerShell:master Dec 10, 2019

Copy link
Copy Markdown
Member

Merged this before waiting for 24 hours, as this blocks nightly build.

Copy link
Copy Markdown

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL