FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Update formatter to not write newlines if content is empty (#11193)" by iSazonov · Pull Request #11342 · PowerShell/PowerShell · GitHub

Revert "Update formatter to not write newlines if content is empty (#11193)" - #11342

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
iSazonov:revert-formatter-null
Dec 17, 2019
Merged

Revert "Update formatter to not write newlines if content is empty (#11193)"#11342
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
iSazonov:revert-formatter-null

Conversation

Ilya (iSazonov) commented Dec 14, 2019
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

This reverts commit 51d2523. (#11193)

PR Context

Fix #11340

It seems we filter out a null too late.
We need to have more info about a scenario we tried to fix in #11193.

PR Checklist

Ilya (iSazonov) added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Dec 14, 2019
Ilya (iSazonov) self-assigned this Dec 14, 2019
Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Dec 14, 2019

Copy link
Copy Markdown
Member

Should we add a test for the Get-Help scenario?

Copy link
Copy Markdown
Collaborator Author

Should we add a test for the Get-Help scenario?

The scenario is a side effect. If we change Get-Help we can lost the new test. I don't know how create more common and reliable test.

Copy link
Copy Markdown
Member

Ilya (@iSazonov) not suggesting we change Get-Help itself, but a test for (Get-Help Out-Null).Examples

Copy link
Copy Markdown
Collaborator Author

I will pull the test in follow PR (revert PR is not right place).

Ilya (iSazonov) merged commit dfb5b04 into PowerShell:master Dec 17, 2019
Ilya (iSazonov) deleted the revert-formatter-null branch December 17, 2019 19:53

Copy link
Copy Markdown
Member

Ilya (@iSazonov) Steve Lee (@SteveL-MSFT) Since #11193 was reverted, is there an issue opened to track the original problem that PR was trying to fix?

Copy link
Copy Markdown
Collaborator Author

Dongbo Wang (@daxian-dbw) Original issue was discovered by Steve Lee (@SteveL-MSFT) but not registered so we haven't tracking issue. I do not know whether it is important for Steve Lee (@SteveL-MSFT).

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get-Help does not display whole example body

5 participants


Back | FazBrowse Home | New Git URL