Make null member access tests as string to avoid parsing errors by adityapatwardhan · Pull Request #11385 · PowerShell/PowerShell · GitHub

PR Summary

PSNullConditionalOperators feature is disabled by default. Hence it causes parsing error when tests are run. This PR converts the tests into here strings and executes them if the feature is enabled.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Looks good. But are you going to make similar changes to the NullConditionalOperator tests in Parser.Tests.ps1 and the tabcompletion test file?

Dongbo Wang (@daxian-dbw) - Added Parsing tests in the PR.

…wershell into FixNullTests

PoshChan-Bot (@PoshChan) please retry linux

Aditya Patwardhan (@adityapatwardhan), successfully started retry of PowerShell-CI-Linux

Hello Aditya Patwardhan (@adityapatwardhan)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

* Make null member access tests as string to avoid parsing errors * Add PSNullConditionalOperators feature to testmetadata.json * Add Parsing tests to be skipped * Add tabcompletion tests

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…rShell#11385) * Make null member access tests as string to avoid parsing errors * Add PSNullConditionalOperators feature to testmetadata.json * Add Parsing tests to be skipped * Add tabcompletion tests

Make null member access tests as string to avoid parsing errors

8f42170

Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Dec 17, 2019

Aditya Patwardhan (adityapatwardhan) added this to the GA-consider milestone Dec 17, 2019

Aditya Patwardhan (adityapatwardhan) requested a review from Dongbo Wang (daxian-dbw) December 17, 2019 20:39

ghost assigned Aditya Patwardhan (adityapatwardhan) Dec 17, 2019

Dongbo Wang (daxian-dbw) approved these changes Dec 17, 2019

View reviewed changes

Dongbo Wang (daxian-dbw) reviewed Dec 17, 2019

View reviewed changes

Comment thread test/powershell/Language/Operators/NullConditional.Tests.ps1

Add PSNullConditionalOperators feature to testmetadata.json

a8cee10

Aditya Patwardhan (adityapatwardhan) requested review from Travis Plunk (TravisEz13) and Andrew (anmenaga) as code owners December 20, 2019 21:59

Merge branch 'master' into FixNullTests

e273e5d

Dongbo Wang (daxian-dbw) approved these changes Dec 20, 2019

View reviewed changes

Add Parsing tests to be skipped

6c73bca

Merge branch 'FixNullTests' of https://github.com/adityapatwardhan/po…

04e07d0

…wershell into FixNullTests

PoshChan-Bot (PoshChan) reviewed Dec 20, 2019

View reviewed changes

Comment thread test/powershell/Language/Operators/NullConditional.Tests.ps1

Add tabcompletion tests

e9bfd1a

Dongbo Wang (daxian-dbw) approved these changes Dec 20, 2019

View reviewed changes

Aditya Patwardhan (adityapatwardhan) added the AutoMerge informs the bot to automerge the PR label Dec 20, 2019

ghost merged commit 2dbb571 into PowerShell:master Dec 21, 2019

Aditya Patwardhan (adityapatwardhan) deleted the FixNullTests branch December 21, 2019 00:22

Aditya Patwardhan (adityapatwardhan) modified the milestones: GA-consider, GA-approved Jan 7, 2020

Dongbo Wang (daxian-dbw) modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020

ghost mentioned this pull request Jan 16, 2020

Null conditional operator tests should be re-written so they don't cause parsing errors when the experimental feature is disabled #11354

Closed

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

This pull request was closed.

Make null member access tests as string to avoid parsing errors by adityapatwardhan · Pull Request #11385 · PowerShell/PowerShell · GitHub

Uh oh!

Make null member access tests as string to avoid parsing errors - #11385

Make null member access tests as string to avoid parsing errors#11385
6 commits merged into
PowerShell:masterfrom
adityapatwardhan:FixNullTests

Aditya Patwardhan (adityapatwardhan) commented Dec 17, 2019 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) left a comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Dec 20, 2019

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Dec 20, 2019

Uh oh!

PoshChan-Bot (PoshChan) commented Dec 20, 2019

Uh oh!

Deleted user (ghost) commented Dec 20, 2019

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Make null member access tests as string to avoid parsing errors by adityapatwardhan · Pull Request #11385 · PowerShell/PowerShell · GitHub

Uh oh!

Make null member access tests as string to avoid parsing errors - #11385

Make null member access tests as string to avoid parsing errors#113856 commits merged intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:FixNullTestsadityapatwardhan/PowerShell:FixNullTestsCopy head branch name to clipboard

Conversation

Aditya Patwardhan (adityapatwardhan) commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) left a comment

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Dec 20, 2019

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Dec 20, 2019

Uh oh!

PoshChan-Bot (PoshChan) commented Dec 20, 2019

Uh oh!

Deleted user (ghost) commented Dec 20, 2019

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Make null member access tests as string to avoid parsing errors#11385
6 commits merged into
PowerShell:masterfrom
adityapatwardhan:FixNullTests

Aditya Patwardhan (adityapatwardhan) commented Dec 17, 2019 •
edited
Loading