FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ignore headers with null values in web cmdlets by iSazonov · Pull Request #11424 · PowerShell/PowerShell · GitHub

Ignore headers with null values in web cmdlets - #11424

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
iSazonov:web-cmdlets-nre
Jan 7, 2020
Merged

Ignore headers with null values in web cmdlets#11424
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
iSazonov:web-cmdlets-nre

Conversation

Ilya (iSazonov) commented Dec 23, 2019
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Core throws if web header has a null value - it is not valid value.
Before the change web cmdlets thrown with NRE (value.ToString()).
Now we silently ignore such headers.

PR Context

PR Checklist

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 23, 2019
Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Dec 23, 2019

Copy link
Copy Markdown
Member

Should we also fix the issue with empty string in this PR?

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) It is another code path. I think we should have different commits.

Travis Plunk (TravisEz13) merged commit e8d472b into PowerShell:master Jan 7, 2020
Ilya (iSazonov) deleted the web-cmdlets-nre branch January 7, 2020 20:26

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL