FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix NRE in ConsiceView by iSazonov · Pull Request #11435 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Fix NRE in ConsiceView - #11435

Merged
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
iSazonov:consiceview-null-check
Jan 14, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Fix NRE in ConsiceView#11435
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
iSazonov:consiceview-null-check

Conversation

Ilya (iSazonov) commented Dec 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Use LanguagePrimitives.TryConvertTo() as last resort to string conversion.

PR Context

Playing with AccountManagement module I catch an error where properties with disposed object reference present.

PS C:\Windows\System32> $e.psobject.properties

GetterScript    : & { Set-StrictMode -Version 1; $this.Exception.InnerException.PSMessageDetails }
SetterScript    :
MemberType      : ScriptProperty
IsSettable      : False
IsGettable      : True
Value           :
TypeNameOfValue : System.Object
Name            : PSMessageDetails
IsInstance      : False

MemberType      : Property
Value           : System.Management.Automation.MethodInvocationException: Exception calling "ToString" with "0"
                  argument(s): "Can�t delete an already deleted object"
                   ---> System.InvalidOperationException: Can�t delete an already deleted object
                     at System.DirectoryServices.AccountManagement.Principal.CheckDisposedOrDeleted()
                     at System.DirectoryServices.AccountManagement.Principal.HandleGet[T](T& currentValue, String
                  name, LoadState& state)
                     at System.DirectoryServices.AccountManagement.Principal.get_Name()
                     at System.DirectoryServices.AccountManagement.Principal.ToString()
                     at CallSite.Target(Closure , CallSite , Object )
                     --- End of inner exception stack trace ---
                     at System.Management.Automation.ExceptionHandlingOps.ConvertToMethodInvocationException(Exception
                  exception, Type typeToThrow, String methodName, Int32 numArgs, MemberInfo memberInfo) in C:\Users\sie
                  \Documents\GitHub\iSazonov\PowerShell\src\System.Management.Automation\engine\runtime\Operations\Misc
                  Ops.cs:line 2062
                     at CallSite.Target(Closure , CallSite , Object )
                     at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
                     at CallSite.Target(Closure , CallSite , Object )
                     at System.Management.Automation.Interpreter.DynamicInstruction`2.Run(InterpretedFrame frame) in C:
                  \Users\sie\Documents\GitHub\iSazonov\PowerShell\src\System.Management.Automation\engine\interpreter\D
                  ynamicInstructions.Generated.cs:line 141
                     at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame
                  frame) in C:\Users\sie\Documents\GitHub\iSazonov\PowerShell\src\System.Management.Automation\engine\i
                  nterpreter\ControlFlowInstructions.cs:line 357
IsSettable      : False
IsGettable      : True
TypeNameOfValue : System.Exception
Name            : Exception
IsInstance      : True

MemberType      : Property
Value           :
IsSettable      : False
IsGettable      : True
TypeNameOfValue : System.Object
Name            : TargetObject
IsInstance      : True

PR Checklist

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 26, 2019
Ilya (iSazonov) added this to the GA-consider milestone Dec 26, 2019
Ilya (iSazonov) self-assigned this Dec 26, 2019
Steve Lee (SteveL-MSFT) approved these changes Jan 3, 2020
View reviewed changes

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Possible to add a test? Seems like we can create an ErrorRecord that hits this code path?

Ilya (iSazonov) commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator Author

Possible to add a test? Seems like we can create an ErrorRecord that hits this code path?

Steve Lee (@SteveL-MSFT) I did not find how to do it :-(

Steve Lee (SteveL-MSFT) commented Jan 7, 2020

Copy link
Copy Markdown
Member

Ilya (@iSazonov) seems like line 802 would have already covered this? Can you show how it looks before and after this change with your error?

Aditya Patwardhan (adityapatwardhan) commented Jan 9, 2020

Copy link
Copy Markdown
Member

Ilya (@iSazonov) Can you provide a repro with your module?

Ilya (iSazonov) commented Jan 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

My fix is not right.

$value = $prop.Value.ToString().Trim()

The line throws if ToString() throws ($prop.Value has a reference on an object with property with disposed object in my case)

I will update the PR.

Steve Lee (SteveL-MSFT) requested changes Jan 10, 2020
View reviewed changes

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok, so it's calling a method on a disposed object.

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 10, 2020

Steve Lee (SteveL-MSFT) commented Jan 13, 2020

Copy link
Copy Markdown
Member

Tried to simulate the original issue of a disposed object, but couldn't find a way to do it.

Ilya (iSazonov) commented Jan 14, 2020

Copy link
Copy Markdown
Collaborator Author

Tried to simulate the original issue of a disposed object, but couldn't find a way to do it.

I too. I could port a code from AccountManagement module but I think it is not correct behavior for ToString() to throw and I will report the issue to Core team.

Ilya (iSazonov) merged commit ac06918 into PowerShell:master Jan 14, 2020
Ilya (iSazonov) deleted the consiceview-null-check branch January 14, 2020 03:33
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Jan 14, 2020
Fix NRE in ConsiceView (#11435)
1ecaae2 
Use LanguagePrimitives.TryConvertTo() as last resort to string conversion.

Deleted user (ghost) commented Jan 16, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Fix NRE in ConsiceView (PowerShell#11435)
404e3f5 
Use LanguagePrimitives.TryConvertTo() as last resort to string conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
+1 more reviewer
PoshChan-Bot (PoshChan) PoshChan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL