Normalize line endings before comparing string in tests by adityapatwardhan · Pull Request #11499 · PowerShell/PowerShell · GitHub

PR Summary

Fix tests which fail on comparing string due to differences in line endings.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Aditya Patwardhan (@adityapatwardhan), your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/debugging/README.md.https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/ should work

Failed to complete request to "https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/". Response status code does not indicate success: 410 (Gone).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

PoshChan-Bot (@PoshChan) please retry static

Aditya Patwardhan (@adityapatwardhan), successfully started retry of PowerShell-CI-static-analysis

Aditya Patwardhan (@adityapatwardhan), your last commit had 2 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/debugging/README.md.https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/ should work

Failed to complete request to "https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/debugging/README.md.https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/ should work

Failed to complete request to "https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/". Response status code does not indicate success: 410 (Gone).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

PoshChan-Bot (@PoshChan) Please rebuild static

Aditya Patwardhan (@adityapatwardhan), successfully started rebuild of PowerShell-CI-static-analysis

Travis Plunk (@TravisEz13) Can you have a look

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…1499)

Normalize line endings before comparing string in tests

3a47d56

ghost assigned Aditya Patwardhan (adityapatwardhan) Jan 6, 2020

Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 6, 2020

Aditya Patwardhan (adityapatwardhan) added this to the GA-consider milestone Jan 6, 2020

PoshChan-Bot (PoshChan) reviewed Jan 6, 2020

View reviewed changes

Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) January 8, 2020 01:10

Travis Plunk (TravisEz13) approved these changes Jan 8, 2020

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit 0097802 into PowerShell:master Jan 8, 2020

Aditya Patwardhan (adityapatwardhan) modified the milestones: GA-consider, GA-approved Jan 14, 2020

Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Jan 14, 2020

Normalize line endings before comparing string in tests (#11499 )

3088496

Dongbo Wang (daxian-dbw) modified the milestones: GA-approved, 7.0.0-rc.2 Jan 14, 2020

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Normalize line endings before comparing string in tests (PowerShell#1…

ee65457

…1499)

Normalize line endings before comparing string in tests by adityapatwardhan · Pull Request #11499 · PowerShell/PowerShell · GitHub

Uh oh!

Normalize line endings before comparing string in tests - #11499

Normalize line endings before comparing string in tests#11499
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixNewLineIssue

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020 •
edited
Loading

Uh oh!

Uh oh!

PoshChan-Bot (PoshChan) Jan 6, 2020

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020

Uh oh!

PoshChan-Bot (PoshChan) commented Jan 6, 2020

Uh oh!

PoshChan-Bot (PoshChan) Jan 6, 2020

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020

Uh oh!

PoshChan-Bot (PoshChan) commented Jan 6, 2020

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 8, 2020

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -5,6 +5,15 @@ Describe 'Basic debugger command tests' -tag 'CI' {

Normalize line endings before comparing string in tests by adityapatwardhan · Pull Request #11499 · PowerShell/PowerShell · GitHub

Uh oh!

Normalize line endings before comparing string in tests - #11499

Normalize line endings before comparing string in tests#11499Aditya Patwardhan (adityapatwardhan) merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:FixNewLineIssueadityapatwardhan/PowerShell:FixNewLineIssueCopy head branch name to clipboard

Conversation

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

PoshChan-Bot (PoshChan) Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020

Uh oh!

PoshChan-Bot (PoshChan) commented Jan 6, 2020

Uh oh!

PoshChan-Bot (PoshChan) Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020

Uh oh!

PoshChan-Bot (PoshChan) commented Jan 6, 2020

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jan 8, 2020

Uh oh!

Deleted user (ghost) commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Normalize line endings before comparing string in tests#11499
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixNewLineIssue

Aditya Patwardhan (adityapatwardhan) commented Jan 6, 2020 •
edited
Loading