FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix SSH remoting test to work on all platforms by PaulHigin · Pull Request #11500 · PowerShell/PowerShell · GitHub

Fix SSH remoting test to work on all platforms - #11500

Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
PaulHigin:fix-ssh-tests
Jan 7, 2020
Merged

Fix SSH remoting test to work on all platforms#11500
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
PaulHigin:fix-ssh-tests

Conversation

Copy link
Copy Markdown
Contributor

PR Summary

One SSH remoting test was failing on some platforms because the returned error id string is slightly different.

PR Context

Depending on platform and error path the returned error id string can be '2100,PSSessionOpenFailed' or 'PSSessionOpenFailed'.
Fix is to update test to just look for the expected 'PSSessionOpenFailed'.

PR Checklist

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) please rebuild all

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan), successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

Aditya Patwardhan (adityapatwardhan) merged commit f22bad1 into PowerShell:master Jan 7, 2020
Paul Higinbotham (PaulHigin) deleted the fix-ssh-tests branch January 8, 2020 16:14
Dongbo Wang (daxian-dbw) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 15, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL