FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update building of MSIX for RC to use 100 range revision by SteveL-MSFT · Pull Request #11526 · PowerShell/PowerShell · GitHub

Update building of MSIX for RC to use 100 range revision - #11526

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:msix-rc
Jan 9, 2020
Merged

Update building of MSIX for RC to use 100 range revision#11526
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:msix-rc

Conversation

Steve Lee (SteveL-MSFT) commented Jan 8, 2020
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Currently, MSIX has two products: PowerShellPreview and PowerShell. The current code looks for preview in the version to determine it is a preview release which misses rc releases. The fix is to check for a - indicating a semver label which means not stable. Second, the product version relies on the semver label to create the revision, so 7.0.0-rc.2 becomes 7.0.2, but this conflicts with 7.0.0-preview.2 which is also 7.0.2 and would also be older than 7.0.0-preview.6 which is 7.0.6. Fix is to increase the revision to the 100 range so, 7.0.0-rc.2 becomes 7.0.102. Since non-preview releases are a separate product, the versioning won't conflict with a serviced 7.0 release.

PR Checklist

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) Can you review as well?

Travis Plunk (TravisEz13) merged commit f61c0d4 into PowerShell:master Jan 9, 2020
Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 15, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log MustHave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL