Correct casing for automatic variables by xtqqczze · Pull Request #11568 · PowerShell/PowerShell · GitHub

PR Summary

Correct casing for special variables (a.k.a. automatic variables)

PR Context

The following code was used to generate a list of special variables:

[psobject].Assembly.GetType('System.Management.Automation.SpecialVariables').GetFields('NonPublic,Static') |
    Where-Object FieldType -eq ([string]) |
    ForEach-Object GetValue $null |
    Where-Object {$_ -imatch '[a-z].+'}

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
User-facing changes
- Not Applicable
Testing - New and feature
- N/A or can only be tested interactively
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

This is a large number of files changed. Would be easier to review if you can change one variable per commit.

Steve Lee (@SteveL-MSFT) OK, I will rewrite

CodeFactor issues are preexisting

Ilya (@iSazonov) why not a squash merge?

Ilya (@iSazonov) Yes please use squash commits. I've remove permissions for merge commits.

GitHub did return an error after I press Squash and Merge button and show something like "Try again", then ok after refresh. :-(
Merge button was disabled some time ago but then was enabled - I don't know why.

Opened issue PowerShell/PSScriptAnalyzer#1401 to detect regressions.

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

* Remove BOM, insert newline at EOF * Correct case of $MyInvocation special variable * Correct case of $OFS special variable * Correct case of $NestedPromptLevel special variable * Correct case of $Matches special variable * Correct case of $LASTEXITCODE special variable * Correct case of $StackTrace special variable * Correct case of $args special variable * Correct case of $this special variable * Correct case of $input special variable * Correct case of $PSCmdlet special variable * Correct case of $error special variable * Correct case of $PSDefaultParameterValues special variable * Correct case of $PSScriptRoot special variable * Correct case of $PWD special variable * Correct case of $null special variable * Correct case of $true special variable * Correct case of $false special variable * Correct case of $PSModuleAutoLoadingPreference special variable * Correct case of $IsLinux special variable * Correct case of $IsMacOS special variable * Correct case of $IsWindows special variable * Correct case of $IsCoreCLR special variable * Correct case of $DebugPreference special variable * Correct case of $VerbosePreference special variable * Correct case of $InformationPreference special variable * Correct case of $ExecutionContext special variable * Correct case of $HOME special variable * Correct case of $Host special variable * Correct case of $PID special variable * Correct case of $PSCulture special variable * Correct case of $PSHOME special variable * Correct case of $PSUICulture special variable * Correct case of $PSVersionTable special variable * Fix false positives

xtqqczze requested review from Steve Lee (SteveL-MSFT), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dongbo Wang (daxian-dbw) and Joey Aiello (joeyaiello) as code owners January 13, 2020 16:07

ghost assigned Ilya (iSazonov) Jan 13, 2020

xtqqczze changed the title Correct casing for automatic variables [WIP]Correct casing for automatic variables Jan 13, 2020

xtqqczze added 20 commits January 13, 2020 18:36

Remove BOM, insert newline at EOF

4f5bb46

Correct case of $MyInvocation special variable

d58e1ff

Correct case of $OFS special variable

fbe459d

Correct case of $NestedPromptLevel special variable

f86f30c

Correct case of $Matches special variable

89e33f5

Correct case of $LASTEXITCODE special variable

04b292a

Correct case of $StackTrace special variable

7dd922a

Correct case of $args special variable

6663261

Correct case of $this special variable

66e0f08

Correct case of $input special variable

a051666

Correct case of $PSCmdlet special variable

42d5043

Correct case of $error special variable

b6a687b

Correct case of $PSDefaultParameterValues special variable

679702b

Correct case of $PSScriptRoot special variable

62aee93

Correct case of $PWD special variable

4a9d70f

Correct case of $null special variable

6014f4b

Correct case of $true special variable

47a3b4e

Correct case of $false special variable

bb58e2a

Correct case of $PSModuleAutoLoadingPreference special variable

9e5bb4e

Correct case of $IsLinux special variable

17d0e93

xtqqczze added 4 commits January 13, 2020 19:35

Correct case of $PSCulture special variable

2782b73

Correct case of $PSHOME special variable

e0d2e2a

Correct case of $PSUICulture special variable

427d17e

Correct case of $PSVersionTable special variable

090ad9c

xtqqczze force-pushed the automatic-variables-case branch from 698aed5 to 090ad9c Compare January 13, 2020 19:38

Fix false positives

a454352