FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Mark failing CertificateProvider tests as pending by xtqqczze · Pull Request #11590 · PowerShell/PowerShell · GitHub

Mark failing CertificateProvider tests as pending - #11590

Closed
xtqqczze wants to merge 4 commits into
PowerShell:masterfrom
xtqqczze:fix-certificateprovider-tests
Closed

Mark failing CertificateProvider tests as pending#11590
xtqqczze wants to merge 4 commits into
PowerShell:masterfrom
xtqqczze:fix-certificateprovider-tests

Conversation

xtqqczze commented Jan 15, 2020
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

PR Checklist

xtqqczze mentioned this pull request Jan 15, 2020
8 tasks
xtqqczze force-pushed the fix-certificateprovider-tests branch from eb3bd6e to 2010383 Compare January 21, 2020 23:33
xtqqczze changed the title [WIP] Fix failing certificateprovider tests Mark failing CertificateProvider tests as failing Jan 21, 2020
xtqqczze force-pushed the fix-certificateprovider-tests branch from 2010383 to bf56f5f Compare January 21, 2020 23:43

xtqqczze commented Jan 21, 2020
edited
Loading

Copy link
Copy Markdown
Contributor Author

PowerShell-CI-static-analysis failure is unrelated, #11653 will fix.

xtqqczze changed the title Mark failing CertificateProvider tests as failing Mark failing CertificateProvider tests as pending Jan 22, 2020
xtqqczze force-pushed the fix-certificateprovider-tests branch from 3f10a2b to ca178c6 Compare January 23, 2020 04:15

Copy link
Copy Markdown

xtqqczze why those -Pending:$true tests start failing after null -> $null change? Is it a test bug or a product bug?

xtqqczze force-pushed the fix-certificateprovider-tests branch from ca178c6 to 2132f1b Compare January 24, 2020 23:06
xtqqczze changed the title Mark failing CertificateProvider tests as pending [WIP]Mark failing CertificateProvider tests as pending Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

81929e4c3cc7973681fe624566433965374a1166 see build 44177

Copy link
Copy Markdown
Contributor Author

81929e4c3cc7973681fe624566433965374a1166 see build 44185

xtqqczze changed the title [WIP]Mark failing CertificateProvider tests as pending Mark failing CertificateProvider tests as pending Jan 25, 2020

xtqqczze commented Feb 1, 2020

Copy link
Copy Markdown
Contributor Author

Andrew (@anmenaga) Please see new commits. It appears some of the tested behaviour is undocumented - I will open new issues.

ghost added the Review - Needed The PR is being reviewed label May 27, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

xtqqczze force-pushed the fix-certificateprovider-tests branch from 806b9dd to de77110 Compare May 28, 2020 03:51
Dongbo Wang (daxian-dbw) added the CommunityDay-Small A small PR that the PS team has identified to prioritize to review label May 15, 2023

Andy Jordan (andyleejordan) left a comment
edited by daxian-dbw
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I approve the code changes, but we need to resolve the conflicts and open an issue to fix the were-failing now-pending tests (which...being this rather old now, need to be re-tested). That's on us maintainers to get done now.

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels May 23, 2023

Dongbo Wang (daxian-dbw) commented Jun 5, 2023
edited
Loading

Copy link
Copy Markdown
Member

There was significant changes to the CertificateProvider.Tests.ps1 file in the past, so it's hard to decide how to resolve the conflicts. Given that, I will close this PR, and only pick those -Be null typo fixes to a new PR #19749.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CommunityDay-Small A small PR that the PS team has identified to prioritize to review Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pester tests for Microsoft.PowerShell.Security are using null incorrectly

5 participants


Back | FazBrowse Home | New Git URL